steffow / meteor-accounts-saml

SAML SP tested with OpenAM
27 stars 29 forks source link

Create XML infosets using a library #18

Closed rhoerbe closed 6 years ago

rhoerbe commented 7 years ago

saml_util.js creates an AuthnRequest using string concatenation with variable substitution. A safer way (for extensibility) would be to use an XML library.

steffow commented 6 years ago

In general yes. BUT: we need npms for this and the dependency checking can be quite painful. Need to balance here. We're already sourcing too many npms if you ask me.