search

steffow / meteor-accounts-saml

SAML SP tested with OpenAM
27 stars 29 forks source link

Correctly parse Attributes with multiple AttributeValues as arrays of strings #27

Open craigdrayton opened 6 years ago

craigdrayton commented 6 years ago

Implemented fix for https://github.com/steffow/meteor-accounts-saml/issues/26

If one AttributeValue exists, it is returned as a string (as per current behaviour). If more than one AttributeValue exists, they are returned as an array of strings.

craigdrayton commented 6 years ago

It may be simpler to keep your manual update and discard the PR :-)

atao60 commented 5 years ago

@steffow thanks for this package. It seems to me that not all the changes of PR #27 have been made in the current code (v0.0.17). Then it's not working as it. I had to change the lines 464 and 466 (v0.0.17) from:

console.log(`Adding attrinute from SAML response to profile:` + attributes[i].getAttribute('Name') + " = " + value.textContent);
profile[attributes[i].getAttribute('Name')] = value.textContent;

to:

console.log(`Adding attribute from SAML response to profile:` + attributes[i].getAttribute('Name') + " = " + value);
profile[attributes[i].getAttribute('Name')] = value;
steffow commented 5 years ago

Hey atao60 - thanks for bringing this up. I would need to look at this, but IIIRC I changed this because it made one of my test fail.

Do you have an example to see the difference?

S.

On 13. Jan 2019, at 09:16, atao60 notifications@github.com wrote:

@steffow thanks for this package. It seems to me that not all the changes of PR #27 have been made in the current code (v0.0.17). Then it's not working as it. I had to change the lines 464 and 466 (v0.0.17) from:

console.log(Adding attrinute from SAML response to profile: + attributes[i].getAttribute('Name') + " = " + value.textContent); profile[attributes[i].getAttribute('Name')] = value.textContent;

to:

console.log(Adding attribute from SAML response to profile: + attributes[i].getAttribute('Name') + " = " + value); profile[attributes[i].getAttribute('Name')] = value;

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

atao60 commented 5 years ago

Do you have an example to see the difference?

@steffow what do you need? Some code in a github repo?