[BUG] incorrect return type None should be BoundingBox - Githubissues

stefmolin / data-morph

Morph an input dataset of 2D points into select shapes, while preserving the summary statistics to a given number of decimal points through simulated annealing. It is intended to be used as a teaching tool to illustrate the importance of data visualization.

https://stefaniemolin.com/data-morph/

MIT License

60 stars 16 forks source link

[BUG] incorrect return type None should be BoundingBox #208

Closed robvdl closed 3 weeks ago

robvdl commented 3 weeks ago

Required attestation

[x] I have checked that this issue has not already been reported.
[x] I have confirmed this bug exists on the latest version.
[x] I have confirmed this bug exists on the main branch.

Describe the bug

The return type of these three methods is set to None, but it returns a BoundingBox:

_derive_data_bounds
_derive_morphing_bounds
_derive_plotting_bounds

To Reproduce It returns BoundingBox but the function signature says the return type is None.

Expected behavior The function signature return type should be BoundingBox.

Screenshots If applicable, add screenshots to help explain your problem.

Environment

OS: Kubuntu 22.04 LTS
Browser Chrome
Python Version 3.12.3
Versions of all Python packages in your environment (i.e., output of pip list/pip freeze)

Additional context Add any other context about the problem here.

github-actions[bot] commented 3 weeks ago

It looks like this is your first issue here – welcome! Please familiarize yourself with the contributing guidelines, if you haven't already.