search

stegano / next-http-proxy-middleware

HTTP Proxy middleware available in API Middleware provided by Next.js.
237 stars 19 forks source link

fix: make jest and ts-jest devDependencies #9

Closed gthb closed 3 years ago

gthb commented 3 years ago

Testing libraries should not be runtime dependencies.

stegano commented 3 years ago

Hi, @gthb

Thanks for your PR! 😀

I think all dependencies can move to devDependencies. 🤔

gthb commented 3 years ago

I think all dependencies can move to devDependencies. 🤔

Oh! Sure, I guess 😊 — I only looked at the ones that were leading to version constraint conflicts in our runtime dependencies.

stegano commented 3 years ago

@all-contributors please add @gthb for code and ideas

allcontributors[bot] commented 3 years ago

@stegano

I've put up a pull request to add @gthb! :tada: