search

steilerDev / homebridge-openhab2-complete

A homebridge plugin for openHAB, that has the expectation to fully support all Services offered by Apple's Homekit Accessory Protocol (HAP)
GNU General Public License v3.0
52 stars 16 forks source link

fix minTemp & maxTemp scaling #114

Closed Matsuo3rd closed 1 year ago

Matsuo3rd commented 1 year ago

minTemp, maxTemp and step properties must also be set on CoolingThresholdTemperature and HeatingThresholdTemperature so the widget's scale can reflect those settings properly. If not, range sticks to 10°C-35°C even if minTemp, maxTemp are set differently in config.json.

steilerDev commented 1 year ago

@Matsuo3rd : Let me know once you found all the bugs and I can release another point release :D

Matsuo3rd commented 1 year ago

Sorry for the frenzic PRs. I am done now and I am not expecting to push any PR soon.

steilerDev commented 1 year ago

No worries, I really appreciate it, keep 'em coming!

And I know how painful it is to wait for a PR getting merged upstream, so I am trying to keep the release cycle as tight as possible, but also don't want to spam npm

Matsuo3rd commented 1 year ago

Completely understandable and understood!