search

steilerDev / homebridge-openhab2-complete

A homebridge plugin for openHAB, that has the expectation to fully support all Services offered by Apple's Homekit Accessory Protocol (HAP)
GNU General Public License v3.0
52 stars 16 forks source link

v0.10.0 Led strip off bug #12

Closed thedavesky closed 5 years ago

thedavesky commented 5 years ago

After update to 0.10.0 version when I change color/brightness of rgb strip, plugin is sending also OFF command which disable leds. On version 0.9.0 everything is ok.

Logs: [2019-3-2 13:43:50] [openHAB2-Complete] Updating state of Strip with item ledstrip to 0,0,100 [2019-3-2 13:43:51] [openHAB2-Complete] Updating state of Strip with item ledstrip to 0,0,51 [2019-3-2 13:43:51] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:51] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:51] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:51] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:52] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:43:52] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:52] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:52] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:52] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:53] [openHAB2-Complete] Updating state of Strip with item ledstrip to 0,0,23 [2019-3-2 13:43:53] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:53] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:53] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:53] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:54] [openHAB2-Complete] Updating state of Strip with item ledstrip to 0,0,48 [2019-3-2 13:43:54] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:54] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:54] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:54] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:58] [openHAB2-Complete] Updating state of Strip with item ledstrip to 0,0,50 [2019-3-2 13:43:58] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:58] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:58] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:58] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:58] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:43:58] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:58] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:58] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:43:58] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:00] [openHAB2-Complete] Updating state of Strip with item ledstrip to 0,0,84 [2019-3-2 13:44:00] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:00] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:00] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:00] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:00] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:00] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:00] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:00] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:00] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:01] [openHAB2-Complete] Updating state of Strip with item ledstrip to 0,0,93 [2019-3-2 13:44:01] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:01] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:01] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:01] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:03] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:03] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:03] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:03] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:03] [openHAB2-Complete] Received push with new state for item ledstrip: 0 [2019-3-2 13:44:04] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:05] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:06] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:07] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:09] [openHAB2-Complete] Updating state of Strip with item ledstrip to 60,100,93 [2019-3-2 13:44:09] [openHAB2-Complete] Received push with new state for item ledstrip: 60 [2019-3-2 13:44:09] [openHAB2-Complete] Received push with new state for item ledstrip: 60 [2019-3-2 13:44:09] [openHAB2-Complete] Received push with new state for item ledstrip: 60 [2019-3-2 13:44:09] [openHAB2-Complete] Received push with new state for item ledstrip: 60 [2019-3-2 13:44:12] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:12] [openHAB2-Complete] Received push with new state for item ledstrip: 60 [2019-3-2 13:44:12] [openHAB2-Complete] Received push with new state for item ledstrip: 60 [2019-3-2 13:44:12] [openHAB2-Complete] Received push with new state for item ledstrip: 60 [2019-3-2 13:44:12] [openHAB2-Complete] Received push with new state for item ledstrip: 60 [2019-3-2 13:44:17] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:17] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:18] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:19] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:19] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:20] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:21] [openHAB2-Complete] Updating state of Strip with item ledstrip to OFF [2019-3-2 13:44:22] [openHAB2-Complete] Updating state of Strip with item ledstrip to 240,100,93 [2019-3-2 13:44:22] [openHAB2-Complete] Received push with new state for item ledstrip: 240 [2019-3-2 13:44:22] [openHAB2-Complete] Received push with new state for item ledstrip: 240 [2019-3-2 13:44:22] [openHAB2-Complete] Received push with new state for item ledstrip: 240 [2019-3-2 13:44:22] [openHAB2-Complete] Received push with new state for item ledstrip: 240

steilerDev commented 5 years ago

Hi @msdos400, I don't understand the issue. Could you please elaborate a bit more and give more details on expected and actual behavior?

Thanks!

thedavesky commented 5 years ago

Hi @steilerDev, I recorded 2 movies to show you the issue.

v0.9.0 (Works properly) https://youtu.be/OekK6Dy31OU

v0.10.0 (OFF bug) https://youtu.be/Sud8oP2vWO0

Regards, David

steilerDev commented 5 years ago

Seems to be related to #13

steilerDev commented 5 years ago

I think I found the issue. It seems to be related to the changes for supporting unit values. I will dig deeper later.

steilerDev commented 5 years ago

As mentioned yesterday I think I found the issue. Could you therefore please manually install the latest commit on the master branch and check if this fixes your issue?

thedavesky commented 5 years ago

I will check it later

thedavesky commented 5 years ago

After update to latest version, turning on, changing brightness and changing colors work well, but I can't turn off the strip. In v0.9.0 and OpenHab panel turning off works ok. https://youtu.be/eY5Sva9dzuU

steilerDev commented 5 years ago

As you can see in the openhab interface the brightness actually gets turned down to 0, I will change this to "OFF" later.

thedavesky commented 5 years ago

Thank you @steilerDev for fixing the bug. On the latest version everything is working properly. When you add the fixes to npm repository?

steilerDev commented 5 years ago

Perfect, great to hear it is working for you now! I want to add the functionality from issue #9 before pushing a new version. However I have got a bit of time during the next days, so I guess until the end of the weekend.

I will keep this issue open and close it as soon as the new version is released, therefore you will be notified. Enjoy using the plugin!

steilerDev commented 5 years ago

Fixed with release V0.10.1