search

steilerDev / homebridge-openhab2-complete

A homebridge plugin for openHAB, that has the expectation to fully support all Services offered by Apple's Homekit Accessory Protocol (HAP)
GNU General Public License v3.0
52 stars 16 forks source link

Bug report: CurrentHeaterCoolerState is mapped wrong in ClimateHeaterCooler #26

Closed maisun closed 5 years ago

maisun commented 5 years ago

Hi, I'd like to report a bug, in ClimateHeaterCooler looks like the current state is mapped incorrectly: let INACTIVE = 0; // = Characteristic.CurrentHeaterCoolerState.INACTIVE let IDLE = 1; // = Characteristic.CurrentHeaterCoolerState.IDLE let HEATING = 1; // = Characteristic.CurrentHeaterCoolerState.HEATING let COOLING = 2; // = Characteristic.CurrentHeaterCoolerState.COOLING

It should be: let INACTIVE = 0; // = Characteristic.CurrentHeaterCoolerState.INACTIVE let IDLE = 1; // = Characteristic.CurrentHeaterCoolerState.IDLE let HEATING = 2; // = Characteristic.CurrentHeaterCoolerState.HEATING let COOLING = 3; // = Characteristic.CurrentHeaterCoolerState.COOLING

Do you accept pull request? I also implemented configurable minStep for fan service and max./min. temperature for climate accessories. (so I can set higher temp >38 for water boiler etc.).

maisun commented 5 years ago

BTW, I have tested the mapping and it works

EjvindHald commented 5 years ago

Hi. I think Frank accepts pull requests, because he writes that in response to my issue # 28 regarding the lock item. Can be found here

If you have time to look into the problem with adding air item mentioned here I would be thankful.

steilerDev commented 5 years ago

Thanks for the input, I updated the source and should push a new point release soon.