search

steilerDev / homebridge-openhab2-complete

A homebridge plugin for openHAB, that has the expectation to fully support all Services offered by Apple's Homekit Accessory Protocol (HAP)
GNU General Public License v3.0
52 stars 16 forks source link

Type list / wrong types in Readme #3

Closed ipweb2000 closed 5 years ago

ipweb2000 commented 5 years ago

Hey Frank,

first of all thanks for the excellent plugin. Makes administration of my native Homekit/Homebridge/Homematic environment much easier and better!

I think there is some mismatch in the types of the readme. Under "Leak Sensor" it says "type motion" and under "Contact Sensor" it says "co2". Could you maybe also provide a list of homekit types in the readme? Thanks and keep it up! Patrick

steilerDev commented 5 years ago

Hi Patrick,

Nice catch, I will change it later when I am in front of my laptop. Copying messed things up a little bit.

I have a list of the supported accessories types at the top of the Supported HAP Services section. If that's not what you are looking for, let me know how to present this information better.

Thanks,

Frank

ipweb2000 commented 5 years ago

Hey Frank,

nice that you are so active in this! Really appreciate this!

I was looking for a reference not to services, but to types. Basically what you can put on the other side of the “type:” nominator.

Cheers, Patrick

On 7. Feb 2019, at 11:08, Frank Steiler notifications@github.com wrote:

Hi Patrick,

Nice catch, I will change it later when I am in front of my laptop. Copying messed things up a little bit.

I have a list of the supported accessories types at the top of the (Supported HAP Services)[ https://github.com/steilerDev/homebridge-openhab2-complete/blob/master/README.md#supported-hap-services] section. If that's not what you are looking for, let me know how to present this information better.

Thanks,

Frank

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/steilerDev/homebridge-openhab2-complete/issues/3#issuecomment-461357858, or mute the thread https://github.com/notifications/unsubscribe-auth/AreqifJwVYoArOUwOGNbR49cqFiPIQgQks5vK_sCgaJpZM4am74N.

steilerDev commented 5 years ago

Hi Patrick,

thanks for the feedback. However, every service has its own type value. Have a lock at my changes on the v0.9.0 branch. I should have fixed all copying issues there, let me know if you can spot any and if the README is now more understandable. Thanks!

steilerDev commented 5 years ago

Fixed with commit 8e1bf78ee474c5d8fd7b5bea7546cd4c86f641c8