steilerDev / homebridge-openhab2-complete

A homebridge plugin for openHAB, that has the expectation to fully support all Services offered by Apple's Homekit Accessory Protocol (HAP)
GNU General Public License v3.0
52 stars 16 forks source link

Valve Service Duration Limit #80

Closed martindenham closed 3 years ago

martindenham commented 4 years ago

Hi, Firstly, a big thanks. This plugin is awesome and it making my life a dream!! I am working with the irrigation service and don't seem to be able to get the right behaviour.

There are two options - either setting the "type" as "irrigation" or setting the "type" as "valve" and the "valveType" to "irrigation".

using the following configuration the item doesn't appear in HomeKit:

                "type": "irrigation",
                "items": [
                    {
                        "name": "Water Grass II",
                        "inUseItem": "Manual_Grass_Watering_Switch",
                        "activeItem": "Manual_Grass_Watering_Switch",
                        "durationItem": "Grass_Watering_Time_Remaining",
                        "programMode": "manual"
                    }
                ]

If, I add the "item" parameter it shows up but the item has no controls

The following configuration works great, however the limit for the "durationItem" it set to a maximum of 60 minutes.:

                "type": "valve",
                "items": [
                    {
                        "name": "Water Grass",
                        "item": "Manual_Grass_Watering_Switch",
                        "inUseItem": "Manual_Grass_Watering_Switch",
                        "valveType": "irrigation",
                        "durationItem": "Grass_Watering_Time_Remaining"
                    },

Looking on the web, here: https://9to5mac.com/2018/06/20/homekit-weekly-009/. Elgato's Eve sprinkler mentions a similar restriction until a firmware upgrade was applied increasing this to 4 x hours.

I am assuming the plugin needs to be updated to increase this to 4 x hours for openhab-complete?

I would like to know if there is any fundamental difference between using irrigation or valve and if the valve method can have an update to four hours?

Thanks in advance, Martin

steilerDev commented 3 years ago

Hi @martindenham ,

sorry for not getting back to you earlier, didn't find the time to work on this and just looking into your issue.

The difference is, that one of them was added before the other to the HAP standard.

The irrigation item does not allow to have durationItem changed (as per Apple's standard), whereas valve allows its durationItem to be changed. The maximum you experience is Apple's standard, however I should be able to overwrite this one. I'll be adding the stuff. Are you still interested in this use case and could validate the changes?

Thanks,

Frank

martindenham commented 3 years ago

Hi Frank,

Thanks for the reply. Yes I am still interested in this use case. Happy to validate the changes but not sure when I will be able to do it – things are pretty hectic at the moment.

Cheers, Martin

From: Frank Steiler notifications@github.com Reply to: steilerDev/homebridge-openhab2-complete reply@reply.github.com Date: Tuesday, 29 September 2020 at 14:34 To: steilerDev/homebridge-openhab2-complete homebridge-openhab2-complete@noreply.github.com Cc: martindenham martinjdenham@gmail.com, Mention mention@noreply.github.com Subject: Re: [steilerDev/homebridge-openhab2-complete] Valve Service Duration Limit (#80)

Hi @martindenhamhttps://github.com/martindenham ,

sorry for not getting back to you earlier, didn't find the time to work on this and just looking into your issue.

The difference is, that one of them was added before the other to the HAP standard.

The irrigation item does not allow to have durationItem changed (as per Apple's standard), whereas valve allows its durationItem to be changed. The maximum you experience is Apple's standard, however I should be able to overwrite this one. I'll be adding the stuff. Are you still interested in this use case and could validate the changes?

Thanks,

Frank

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/steilerDev/homebridge-openhab2-complete/issues/80#issuecomment-700706865, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEVSZJYLCHBMJV5FPCKY6BTSIHO6BANCNFSM4NHURIMA.

steilerDev commented 3 years ago

Fixed with 1.3.0