search

steilerDev / homebridge-openhab2-complete

A homebridge plugin for openHAB, that has the expectation to fully support all Services offered by Apple's Homekit Accessory Protocol (HAP)
GNU General Public License v3.0
52 stars 16 forks source link

Bug in ClimateHeaterCooler.js #84

Closed maisun closed 3 years ago

maisun commented 4 years ago

Maybe a typo: let INACTIVE = 0; // = Characteristic.CurrentHeaterCoolerState.INACTIVE let IDLE = 1; // = Characteristic.CurrentHeaterCoolerState.IDLE let HEATING = 1; // = Characteristic.CurrentHeaterCoolerState.HEATING let COOLING = 2; // = Characteristic.CurrentHeaterCoolerState.COOLING Line 112-115 should be: let INACTIVE = 0; // = Characteristic.CurrentHeaterCoolerState.INACTIVE let IDLE = 1; // = Characteristic.CurrentHeaterCoolerState.IDLE let HEATING = 2; // = Characteristic.CurrentHeaterCoolerState.HEATING let COOLING = 3; // = Characteristic.CurrentHeaterCoolerState.COOLING

Matsuo3rd commented 3 years ago

@maisun: nice catch! My device not reflecting the proper state in Home app was driving me nuts. I made the update recommended above and it is now working like a charm. Thanks a ton.

steilerDev commented 3 years ago

Thanks for that, I'll fix it in the next release!

steilerDev commented 3 years ago

Fixed with 1.3.0