search

steilerDev / icloud-photos-sync

One-way sync engine for the iCloud Photos Library into the native file system
https://icps.steiler.dev/
GNU General Public License v3.0
340 stars 9 forks source link

iCloud China Support #286

Closed Sowevo closed 11 months ago

Sowevo commented 1 year ago

Checklist before opening an issue

Describe the bug

hello, I'm from China, Using iCloud in China will have another domain name https://www.icloud.com.cn If you use https://www.icloud.com directly, a 302 error will occur

I try to directly modify the domain name in the source code constants.ts, it can work normally after modification

https://github.com/steilerDev/icloud-photos-sync/blob/f895d9aaa51f2646c8aade0d43175b89e43e2c48/app/src/lib/icloud/constants.ts#L46-L51

Error code

Share the Error Code generated upon the crash

Experienced fatal error at 2023/7/8 04:15:47: APP_SYNC (FATAL): Sync failed caused by AUTH_FAILED (FATAL): iCloud Authentication failed caused by AUTH_ACCOUNT_SETUP (FATAL): Unable to setup iCloud Account caused by Request failed with status code 302 (Error Code: 9d68a789-8bfb-40cf-982a-5032f67b4a9c)

Logs

Please paste the log file (preferably with LOG_LEVEL=debug), located in .icloud-photos-sync.log, stored in the DATA_DIR.

Operating environment

Sowevo commented 1 year ago

Maybe add an option to modify this parameter

steilerDev commented 1 year ago

As I don't have access to a Chinese iCloud account, I would need someone from China implementing this feature - no way for me to test or validate.

Happy to point in the right directions, but this would be a feature that needs to be supplied by the community with access to this.

github-actions[bot] commented 11 months ago

This issue should be resolved with version v1.2.1-beta.1, please confirm.

steilerDev commented 11 months ago

@Sowevo since I don't have an iCloud China account - could you please try and confirm by setting --region china / REGION="china"?

Sowevo commented 11 months ago

@Sowevo since I don't have an iCloud China account - could you please try and confirm by setting --region china / REGION="china"?

After my try, this option works fine, thank you very much

steilerDev commented 11 months ago

Awesome, thanks for confirming - closing this issue.

github-actions[bot] commented 11 months ago

This issue was resolved with version v1.3.0.