Closed mzaferyahsi closed 12 months ago
Try turning error reporting off for this - need to make sure to handle masking confidential data differently it seems.
After doing some analysing, I noticed that I have three zones;
[
{
zoneID: {
zoneName: 'PrimarySync',
ownerRecordName: '_5d8a4591d58a4fe577090ceb96ec9233',
zoneType: 'REGULAR_CUSTOM_ZONE'
}
},
{
zoneID: {
zoneName: 'SharedSync-1F27FFE9-AB6C-4F4C-B970-EB46CBA18B16',
ownerRecordName: '_5d8a4591d58a4fe577090ceb96ec9233',
zoneType: 'REGULAR_CUSTOM_ZONE'
}
},
{
zoneID: {
zoneName: 'CMM-6A3D1806-A29C-44C0-A710-5BDDE8681D61',
ownerRecordName: '_5d8a4591d58a4fe577090ceb96ec9233',
zoneType: 'REGULAR_CUSTOM_ZONE'
}
}
]
Very interesting...do you have any special setup in iCloud that could explain the third zone?
I have a family account with my wife, nothing special. But I do have some shared albums with other icloud accounts (like my sister, and other friends). That's the only thing I can think of.
Is there a way to check what's inside in that third zone?
You could try the postman collection within the repo - there are basically all functions in there, you'd need to swap the zone name and owner to retrieve the data from the zone
I can only run the Get Photos by Start Rank
and it returns two records.
One with "recordType": "CPLMaster",
which is a video that is actually in my shared library when I look via the Photos app on my Mac and the other is "recordType": "CPLAsset",
linked to the CPLMaster with the following master reference value.
"masterRef": {
"value": {
"recordName": "AfbwGCXra8EQRu0L6bgxm9R+vTLH",
"action": "DELETE_SELF",
"zoneID": {
"zoneName": "CMM-6A3D1806-A29C-44C0-A710-5BDDE8681D61",
"ownerRecordName": "_5d8a4591d58a4fe577090ceb96ec9233",
"zoneType": "REGULAR_CUSTOM_ZONE"
}
},
"type": "REFERENCE"
},
...
"parent": {
"recordName": "cmm-root"
}
One special thing I can think of is that my iCloud space is full. That's why the rush on using the tool to backup the images so I can open up some space.
I see - so it feels like Dave to ignore?
You should be able to alter the photos response Schema (bin /lib/resources/schemas/photos-setup-response.json) to temporarily allow the array to be bigger - the code should be able to only pick up the primary and shared zone.
Currently don't have access to a laptop, so it will be only next week when I can implement the changes.
I did download the repo and modified the code to confirm, indeed it works when I increase the limit. The problem is that that video is still a valid video that I want to backup. I downloaded it and backed it up and deleted from iCloud manually for now. Let's see if the zone is deleted afterwards. It might be good to log additional zones are created at least to be able to track if there are any valuable assets that needs to be backed up.
The question would be if the video is included in any of the other zones - and just a duplicate indicating full storage - but yeah, a warning might be a good idea.
So, it seems that I've shared this video with a friend via iMessage but instead of directly sending it, I've shared it as a link as it seems. On the iCloud Photos Web Interface I see iCloud Links
and it only contains this video. We can treat it as a duplicate, though deleting the one from my library didn't delete this one and I had to manually search where I shared this video.
If that can help, I had a similar error, having two SharedSync
, but with a different reason.
The second one is marked as deleted
this way:
{
"zoneID": {
"zoneName": "SharedSync-ABC123",
"ownerRecordName": "_abc123",
"zoneType": "REGULAR_CUSTOM_ZONE"
},
"deleted": true
}
Calling any API with this zoneName returns ZONE_NOT_FOUND
errors.
Postman collection can be adapted with if(zones[i].zoneID.zoneName.startsWith(library) && !zones[i].deleted) {
I did look into code, but sorry I'm a bit puzzled by the validation logic to be confident at submitting a PR. For now just naively increased the maxItems
to 3, as suggested in the thread (thanks!), which I guess works as the deleted is the last.
@vguerci are you sure about the structure? I'd expect
{
"zoneID": {
"zoneName": "SharedSync-ABC123",
"ownerRecordName": "_abc123",
"zoneType": "REGULAR_CUSTOM_ZONE"
"deleted": true
},
}
If not could you please provide the full response object to https://setup.icloud.com/setup/ws/1/accountLogin
?
P.S.: Validation is based on the schema that is generated from src/lib/resources/network-types.ts
- extraction happens in src/lib/icloud/icloud.ts#setupAccount()
Nevermind - I missed something here, your example makes sense.
This issue should be resolved with version v1.2.0-beta.5, please confirm.
Works for me, will report if I find any other issues, thanks :)
And yes I confirm my example, that was just a copy-paste excerpt of response.
Checklist before opening an issue
Describe the bug
App crashes right after the sign in.
Error code
No error code is generated.
Logs
Operating environment