search

steinbergmedia / vst3_pluginterfaces

VST 3 API
Other
24 stars 18 forks source link

buffer overflow/memory corruption #15

Closed defiantnerd closed 11 months ago

defiantnerd commented 11 months ago

https://github.com/steinbergmedia/vst3_pluginterfaces/blob/37de655a51b28a558645621b39d48a00292be5e2/base/fstrdefs.h#L249

a buffer overflow can appear in str8toStr16(). Fix would be to compare if ( i == n-1 ).

n is the size of the buffer, but used as index in the next operation writing behind the string buffer.

ygrabit commented 11 months ago

Thanks for finding it... It will be fixed in next update