steinbergmedia / vst3_public_sdk

VST 3 Implementation Helper Classes And Examples
Other
140 stars 47 forks source link

Validator gives incorrect "Valid State Transition" test failure if plugin does not support 32bit samples #26

Closed mikeoliphant closed 3 years ago

mikeoliphant commented 3 years ago

The validator application's "Valid State Transition" test is done using a 32bit sample configuration even if the plugin has reported that it only supports 64bit samples. This results in an incorrect test error when setupProcessing returns kResultFalse.

Instead, the test should be done with a 64bit sample configuration if that is the only configuration the plugin supports.

ygrabit commented 3 years ago

//------------------------------------------------------------------------ bool PLUGIN_API ValidStateTransitionTest::run (ITestResult* testResult) { if (!testResult || !vstPlug || !audioEffect) return false;

printTestHeader (testResult);
if (!canProcessSampleSize (testResult))
    return true;

the added check canProcessSampleSize will avoid to mark the test as failure when not supported SampleSize. Part of the next SDK update

mikeoliphant commented 3 years ago

Thanks!