search

steinbergmedia / vst3_public_sdk

VST 3 Implementation Helper Classes And Examples
Other
139 stars 46 forks source link

Virtual function called from destructor #70

Closed reuk closed 3 months ago

reuk commented 3 months ago

https://github.com/steinbergmedia/vst3_public_sdk/blob/3f20bcbf36283b1e5c450e088571be6226cd4e64/source/common/pluginview.cpp#L54

It's generally regarded to be a bad idea to call virtual functions from constructors and destructors. The Core Guidelines discussion on the topic can be found here.

The highlighted line triggers the clang-analyzer-optin.cplusplus.VirtualCall clang-tidy check.

ygrabit commented 3 months ago

Thanks for notifying this, the call setFrame will be removed in the next update.