search

steinbergmedia / vst3sdk

VST 3 Plug-In SDK
Other
1.57k stars 162 forks source link

missing <limits> #103

Closed noisecode3 closed 1 year ago

noisecode3 commented 1 year ago

Hi, I'm maintaining a package on Slackware Linux and I got an error that std::numeric_limits definition is missing in public.sdk/source/vst/moduleinfo/moduleinfoparser.cpp so I added like so

// OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
// OF THE POSSIBILITY OF SUCH DAMAGE.
//-----------------------------------------------------------------------------

#include "moduleinfoparser.h"
#include "jsoncxx.h"
#include "pluginterfaces/base/ipluginbase.h"
#include <stdexcept>
#include <limits>

//------------------------------------------------------------------------
namespace Steinberg::ModuleInfoLib {
namespace {

//------------------------------------------------------------------------
void printJsonParseError (json_parse_result_s& parseResult, std::ostream& errorOut)

Now the build works and passes all tests, I tried 3 times. But with some warnings

/home/marbangens/vst3sdk/base/source/fstring.cpp:296:2: warning: #warning DEPRECATED No Linux implementation [-Wcpp]
  296 | #warning DEPRECATED No Linux implementation
      |  ^~~~~~~
/home/marbangens/vst3sdk/base/source/fstring.cpp:320:2: warning: #warning DEPRECATED No Linux implementation [-Wcpp]
  320 | #warning DEPRECATED No Linux implementation
      |  ^~~~~~~
/home/marbangens/vst3sdk/base/source/fstring.cpp:1598:10: warning: #warning DEPRECATED No Linux implementation [-Wcpp]
 1598 |         #warning DEPRECATED No Linux implementation
      |          ^~~~~~~
/home/marbangens/vst3sdk/base/source/fstring.cpp:1627:10: warning: #warning DEPRECATED No Linux implementation [-Wcpp]
 1627 |         #warning DEPRECATED No Linux implementation
      |          ^~~~~~~
/home/marbangens/vst3sdk/base/source/fstring.cpp:1926:2: warning: #warning DEPRECATED No Linux implementation [-Wcpp]
 1926 | #warning DEPRECATED No Linux implementation
      |  ^~~~~~~
/home/marbangens/vst3sdk/base/source/fstring.cpp:2007:2: warning: #warning DEPRECATED No Linux implementation [-Wcpp]
 2007 | #warning DEPRECATED No Linux implementation
      |  ^~~~~~~
/home/marbangens/vst3sdk/base/source/timer.cpp:362:2: warning: #warning DEPRECATED No Linux implementation [-Wcpp]
  362 | #warning DEPRECATED No Linux implementation
      |  ^~~~~~~
/home/marbangens/vst3sdk/vstgui4/vstgui/lib/platform/linux/cairobitmap.cpp:222:2: warning: #warning TODO: alphaPremultiplied is currently ignored, always treated as true [-Wcpp]
  222 | #warning TODO: alphaPremultiplied is currently ignored, always treated as true
      |  ^~~~~~~
/home/marbangens/vst3sdk/vstgui4/vstgui/lib/platform/linux/cairocontext.cpp:455:2: warning: #warning TODO: Implementation [-Wcpp]
  455 | #warning TODO: Implementation
      |  ^~~~~~~
/home/marbangens/vst3sdk/vstgui4/vstgui/lib/platform/linux/cairocontext.cpp:553:2: warning: #warning TODO: Implementation [-Wcpp]
  553 | #warning TODO: Implementation
      |  ^~~~~~~
/home/marbangens/vst3sdk/vstgui4/vstgui/lib/platform/linux/x11frame.cpp:744:2: warning: #warning TODO: Implementation [-Wcpp]
  744 | #warning TODO: Implementation
      |  ^~~~~~~
/home/marbangens/vst3sdk/vstgui4/vstgui/lib/platform/linux/x11frame.cpp:751:2: warning: #warning TODO: Implementation [-Wcpp]
  751 | #warning TODO: Implementation
      |  ^~~~~~~
/home/marbangens/vst3sdk/vstgui4/vstgui/lib/platform/linux/x11frame.cpp:790:2: warning: #warning TODO: Implementation [-Wcpp]
  790 | #warning TODO: Implementation
      |  ^~~~~~~
ygrabit commented 1 year ago

Thanks , this will be fixed in next update...