search

steinbergmedia / vst3sdk

VST 3 Plug-In SDK
Other
1.59k stars 162 forks source link

cmake errors in new release #43

Closed stawrocek closed 4 years ago

stawrocek commented 4 years ago

Hi! It looks like cmake is broken in newest release (but works in previous): I did everything according to README.md for Windows (Win10, VS 16 2019)

git clone --recursive https://github.com/steinbergmedia/vst3sdk.git
cd vst3sdk && mkdir build && cd build
cmake.exe -G "Visual Studio 16 2019" -A x64 ../

This gives errors:

cmake.exe -G "Visual Studio 16 2019" -A x64 ../
CMake Error at cmake/modules/AddVST3Options.cmake:31 (file):
  file problem creating directory: C:/Program Files/Common Files/VST3
Call Stack (most recent call first):
  cmake/modules/SMTG_VST3_SDK.cmake:13 (include)
  CMakeLists.txt:10 (include)

-- SMTG_PLUGIN_TARGET_PATH is not set!
-- SMTG_MYPLUGINS_SRC_PATH is not set. If you want to add your own plug-ins folder, specify it!
-- SMTG_PACKAGE_ICON_PATH is set to : C:/Users/USERNAME/Libraries/vst3sdk/doc/artwork/VST_Logo_Steinberg.ico
-- Selecting Windows SDK version 10.0.18362.0 to target Windows 10.0.17763.
-- The C compiler identification is MSVC 19.23.28106.4
-- The CXX compiler identification is MSVC 19.23.28106.4
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/Hostx64/x64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Could NOT find EXPAT (missing: EXPAT_LIBRARY EXPAT_INCLUDE_DIR)
-- VSTGUI will use the embedded Expat package!
-- VSTGUI_ROOT is set to : C:/Users/USERNAME/Libraries/vst3sdk
-- SMTG_AAX_SDK_PATH is not set. If you need it, please download the AAX SDK!
-- Configuring incomplete, errors occurred!

However when I checkout to previous commit:

commit 92351625c5b24d5805a3f5adcc718fc748a5720a
Author: scheffle <scheffle@users.noreply.github.com>
Date:   Thu May 9 13:28:52 2019 +0200

    [fix] linux part for audiohost sample
    [fix] cmake for Jack support
git checkout 92351625c5b24d5805a3f5adcc718fc748a5720a
git submodule update --recursive

Then everything is generated properly and even built properly later with fixes for _SILENCE_EXPERIMENTAL_FILESYSTEM_DEPRECATION_WARNING (issue #39)

scheffle commented 4 years ago

Hi, thanks for the report, please make "C:/Program Files/Common Files/VST3" read/write accessible to any user. If that folder does not yet exist, please create it. Afterwards cmake should run without errors.

scheffle commented 4 years ago

No answer from user, closing.

jean25marc commented 4 years ago

Hi,

I have the same issue with cmakfile, an a other error can we re open this thread ?

1> La génération de CMake a démarré pour la configuration : 'x64-Debug'.
1> Ligne de commande : "cmd.exe" /c ""c:\program files (x86)\microsoft visual studio\2019\community\common7\ide\commonextensions\microsoft\cmake\CMake\bin\cmake.exe"  -G "Ninja" -DCMAKE_INSTALL_PREFIX:PATH="C:\utilitaires\vst3sdk-master\out\install\x64-Debug" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/HostX64/x64/cl.exe" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/HostX64/x64/cl.exe"  -DCMAKE_BUILD_TYPE="Debug" -DCMAKE_MAKE_PROGRAM="c:\program files (x86)\microsoft visual studio\2019\community\common7\ide\commonextensions\microsoft\cmake\Ninja\ninja.exe" "C:\utilitaires\vst3sdk-master" 2>&1"
1> Répertoire de travail : C:\utilitaires\vst3sdk-master\out\build\x64-Debug
1> [CMake] CMake Error at C:\utilitaires\vst3sdk-master\CMakeLists.txt:10 (include):
1> [CMake]   include could not find load file:
1> [CMake] 
1> [CMake]     SMTG_VST3_SDK
1> [CMake] 
1> [CMake] 
1> [CMake] CMake Error at C:\utilitaires\vst3sdk-master\CMakeLists.txt:17 (setupPlatformToolset):
1> [CMake]   Unknown CMake command "setupPlatformToolset".
1> [CMake] 
1> [CMake] 
1> [CMake] -- Configuring incomplete, errors occurred!
1> [CMake] See also "C:/utilitaires/vst3sdk-master/out/build/x64-Debug/CMakeFiles/CMakeOutput.log".
1> [CMake] 
1> cmd.exe /c ""c:\program files (x86)\microsoft visual studio\2019\community\common7\ide\commonextensions\microsoft\cmake\CMake\bin\cmake.exe"  -G "Ninja" -DCMAKE_INSTALL_PREFIX:PATH="C:\utilitaires\vst3sdk-master\out\install\x64-Debug" -DCMAKE_CXX_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/HostX64/x64/cl.exe" -DCMAKE_C_COMPILER:FILEPATH="C:/Program Files (x86)/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.23.28105/bin/HostX64/x64/cl.exe"  -DCMAKE_BUILD_TYPE="Debug" -DCMAKE_MAKE_PROGRAM="c:\program files (x86)\microsoft visual studio\2019\community\common7\ide\commonextensions\microsoft\cmake\Ninja\ninja.exe" "C:\utilitaires\vst3sdk-master" 2>&1" a été retourné avec le code de sortie : 1

and Common File/VST3 permission does not seem badly configured. Here The ACL configuration (The group CREATEUR PROPRIETAIRE (creator owner) seem to inherit from others permissions)


    Répertoire : C:\Program Files\Common Files

Path Owner                   Access                                                                                                  
---- -----                   ------                                                                                                  
VST3 BUILTIN\Administrateurs AUTORITE NT\Système Allow  FullControl...                                                               

Path   : Microsoft.PowerShell.Core\FileSystem::C:\Program Files\Common Files\VST3\
Owner  : BUILTIN\Administrateurs
Group  : PC-NOEUD-SOLEIL\Aucun
Access : AUTORITE NT\Système Allow  FullControl
         BUILTIN\Administrateurs Allow  FullControl
         BUILTIN\Utilisateurs Allow  FullControl
         NT SERVICE\TrustedInstaller Allow  FullControl
         AUTORITÉ DE PACKAGE D’APPLICATION\TOUS LES PACKAGES D’APPLICATION Allow  FullControl
         AUTORITÉ DE PACKAGE D’APPLICATION\TOUS LES PACKAGES D’APPLICATION RESTREINTS Allow  FullControl
         NT SERVICE\TrustedInstaller Allow  FullControl
         NT SERVICE\TrustedInstaller Allow  268435456
         AUTORITE NT\Système Allow  FullControl
         AUTORITE NT\Système Allow  268435456
         BUILTIN\Administrateurs Allow  FullControl
         BUILTIN\Administrateurs Allow  268435456
         BUILTIN\Utilisateurs Allow  ReadAndExecute, Synchronize
         BUILTIN\Utilisateurs Allow  -1610612736
         CREATEUR PROPRIETAIRE Allow  268435456
         AUTORITÉ DE PACKAGE D’APPLICATION\TOUS LES PACKAGES D’APPLICATION Allow  ReadAndExecute, Synchronize
         AUTORITÉ DE PACKAGE D’APPLICATION\TOUS LES PACKAGES D’APPLICATION Allow  -1610612736
         AUTORITÉ DE PACKAGE D’APPLICATION\TOUS LES PACKAGES D’APPLICATION RESTREINTS Allow  ReadAndExecute, Synchronize
         AUTORITÉ DE PACKAGE D’APPLICATION\TOUS LES PACKAGES D’APPLICATION RESTREINTS Allow  -1610612736
Audit  : 
Sddl   : O:BAG:S-1-5-21-4235948370-3488716185-663264605-513D:AI(A;OICI;FA;;;SY)(A;OICI;FA;;;BA)(A;OICI;FA;;;BU)(A;OICI;FA;;;S-1-5-80-
         956008885-3418522649-1831038044-1853292631-2271478464)(A;OICI;FA;;;AC)(A;OICI;FA;;;S-1-15-2-2)(A;ID;FA;;;S-1-5-80-956008885-
         3418522649-1831038044-1853292631-2271478464)(A;CIIOID;GA;;;S-1-5-80-956008885-3418522649-1831038044-1853292631-2271478464)(A
         ;ID;FA;;;SY)(A;OICIIOID;GA;;;SY)(A;ID;FA;;;BA)(A;OICIIOID;GA;;;BA)(A;ID;0x1200a9;;;BU)(A;OICIIOID;GXGR;;;BU)(A;OICIIOID;GA;;
         ;CO)(A;ID;0x1200a9;;;AC)(A;OICIIOID;GXGR;;;AC)(A;ID;0x1200a9;;;S-1-15-2-2)(A;OICIIOID;GXGR;;;S-1-15-2-2)
kmturley commented 4 years ago

I was getting the same error, looks like an issue with the git submodules. When I ran: git submodule update --init --recursive

The issue was fixed!