search

steinbergmedia / vstgui

A user interface toolkit mainly for audio plug-ins
Other
869 stars 124 forks source link

Add cassert include #240

Closed etheory closed 2 years ago

etheory commented 2 years ago

On Windows, without the cassert include, you get: "cviewcontainer_test.cpp(112,1): error C3861: 'assert': identifier not found"

scheffle commented 2 years ago

Thanks for the fix, but the assert was already removed in a previous commit. So it's unnecessary now to include <cassert>.

etheory commented 2 years ago

If you remove the include, it doesn't compile on Windows 10, Visual Studio 16 2019, so yes, you DO need the include. I'm not sure why you closed this PR. Unless the documentation is wrong and misses a step that allows it to compile without the include. Do you have further info on this? Thanks.

scheffle commented 2 years ago

As already written, on the develop branch is already a commit which has removed the use of the assert. There's a GitHub Action that compiles the code with Visual Studio 2019 successfully.