steineggerlab / foldseek

Foldseek enables fast and sensitive comparisons of large structure sets.
https://foldseek.com
GNU General Public License v3.0
696 stars 92 forks source link

compilation fails under gcc 13 #169

Closed joelb123 closed 11 months ago

joelb123 commented 11 months ago

Expected Behavior

Compilation completes without error under gcc 13.1.1 (patch 20230527).

Current Behavior

Steps to Reproduce (for bugs)

Usual cmake and make/ninja.

Context

Works under gcc 12.3. For gcc>12, definitions of many standard integer types has moved to , so roughly 129 files throw errors of the type error: ‘uint64_t’ does not name a type.

Your Environment

Include as many relevant details about the environment you experienced the bug in.

milot-mirdita commented 11 months ago

We had the following PR that should have fixed most of these issues: https://github.com/soedinglab/MMseqs2/pull/714

I can't reproduce the build failure with neither Conda's GCC 13.1.0 or a fresh docker image with debian unstable (GCC 13.2).

Could you check if this was indeed the latest Foldseek head? Maybe we fixed the issue by accident in the meantime.

joelb123 commented 11 months ago

I built it from head yesterday under gcc 13.2 without problems, so you must have fixed it.

Thank you.