search

steinitzu / celery-singleton

Seamlessly prevent duplicate executions of celery tasks
MIT License
237 stars 36 forks source link

celery 5 compatibility #30

Closed wangsha closed 3 years ago

wangsha commented 3 years ago

this PR fixes #28

steinitzu commented 3 years ago

Great! Thank you! And 👍for cleaning out the requirements files.

Can you add a version matrix to Travis to test both 4 and 5? I would also prefer to have the dependency pinned as >=4 in pyproject. Same with the other dependencies, avoid wildcards ideally (was there a problem with any of the versions in there before?)

And python 3.5 still works with celery 5 right? If there's no extra work to maintain it for now keep 3.5 support

wangsha commented 3 years ago

celery 5 dropped python 3.5 rest suggestions fixed.

steinitzu commented 3 years ago

Thank you @wangsha