Closed Elukej closed 1 year ago
@jpihl , @loglund Please guys
Hi @Elukej,
I appreciate your interest in the project and the effort you put into your contribution. After reviewing your changes, I don't think the setCapacity
function fits with the project's current goals and use cases, so I don't plan to merge it into the library.
Please keep in mind that this decision isn't a reflection of the quality of your work, and I encourage you to keep contributing to open-source projects. Thank you for your understanding.
This library has one of the best comments I've seen in open source community, so I did my best to comment everything very thoroughly. The
allocaton_policy
that I explained in discussion with @jpihl in the issue for this pull request is inLIMIT
mode, so do check that discussion first before going into the code. Main features added are capacity setter and getter which are putting hard limit to how many resources canshared_pool
accept. There is also aused_resources
function which gets how many resources are currently used and tracked by theshared_pool
.