add-dialog broken since 1.4.0

steirico / kirby-plugin-custom-add-fields

Custom fields for Kirby's add dialog.

MIT License

36 stars 4 forks source link

add-dialog broken since 1.4.0 #33

Closed andreasotto closed 3 years ago

andreasotto commented 3 years ago

I've included your plugin as a git submodule and when i switch from 1.3.2 to 1.4.0 the add-dialog is broken: It is empty.

Tested with kirby version from 3.3.6 up to 3.4.2

When i switch back to 1.3.2 everything works again as expected.

I did not change anything in the blueprints.

The add-dialog is empty in every blueprint, it doesn't matter if i have a addField: defined or not. Even the standard add dialogs are empty as soon as i switch to 1.4.0.

Please let me know if you need any further information. I'll send them quickly to help to get the issue fixed.

steirico commented 3 years ago

I doubt the issue is related to git submodules since I use the plugin in my projects in the same manner.

For kirby v3.4.3 you have to use v1.4.0 of the plugin (c.f. #28)

Does this happen when adding new pages to the site or when adding new pages to an existing page? Could you check these two cases, please?

andreasotto commented 3 years ago

Both cases:

add a new page to the site
add a new child to a parent page

I just tried it again with Kirby 3.4.3 and kirby-plugin-custom-add-fields 1.4.0 which results in an empty modal dialog like shown above.

steirico commented 3 years ago

Could you try if branch feature/fix-regression fixes the issue?

andreasotto commented 3 years ago

Yes, that fixes it for me. The contents of the dialog are there again! ✅

steirico commented 3 years ago

@mvilskersts this issue is a regression from #27.

Could you check if the fix in branch feature/fix-regression still works for your use cases?

iskrisis commented 3 years ago

@steirico well for me it fixed redirects actually. They jump to some error page but immediately redirect to proper page. This happens even if i provide title/slug. But better wierd jump than no redirect honestly.

mvilskersts commented 3 years ago

@steirico Finally got to using the latest version. feature/fix-regression seems to fix the issue introduced with my PR.

steirico commented 3 years ago

@iskrisis

@steirico well for me it fixed redirects actually. They jump to some error page but immediately redirect to proper page. This happens even if i provide title/slug. But better wierd jump than no redirect honestly.

This seems to be off-topic for me. Could you open a new issue und provide steps and blueprint excerpts to reproduce the behaviour, please?