search

steirico / kirby-plugin-custom-add-fields

Custom fields for Kirby's add dialog.
MIT License
36 stars 4 forks source link

URL sync stops working with kirby 3.8.3 #67

Open squareclouds opened 1 year ago

squareclouds commented 1 year ago

hi everyone,

i updated today to kirby 3.8.3 and the plugin (and even pages/sections that dont use the plugin) stoped working, so overall the URL sync stops working. if i remove the plugin everything works fine again. any ideas?

kirby 3.8.3 php 8.1 plugin version 2.0.0

Bildschirm­foto 2022-12-15 um 10 16 35

vivaneo commented 1 year ago

I noticed the same problem. php8.0

I wonder what could have changed

afbora commented 1 year ago

We guess that this is the source of the problem: https://github.com/getkirby/kirby/issues/4953

steirico commented 1 year ago

Thanks for reporting.

There seems to be few changes in kirby introducing regressions.

I will have a look into this in the next days.

steirico commented 1 year ago

Give 3.0.0-beta1 a try, please.

Happy New Year!

squareclouds commented 1 year ago

seems to be working now, but i only tested quite quickly. lets wait for someone else

afbora commented 1 year ago

@steirico FYI: Some changes will be reverted on 3.8.4. Maybe you need to double check, before your new release: https://github.com/getkirby/kirby/pull/4982

steirico commented 1 year ago

@afbora Thanks for the hint!

steirico commented 1 year ago

IMHO, kirby 3.8.4 fixed the regression that also broke this plugin.

Please check if v2.0.0 of the plugin works as expect with kirby 3.8.4.