search

steiza / docstore

For any civics-minded organization that needs a simple place to host documents publicly
http://a2docs.org/
7 stars 4 forks source link

Add basic RSS feed for Recent Uploads #27

Closed cdzombak closed 5 years ago

cdzombak commented 5 years ago

closes #26

@steiza / @eby, what is the pathway to getting this reviewed/merged/deployed?

eby commented 5 years ago

Checked this out to https://qa.a2docs.org

As an aside had to install python3-lxml in order to install feedgen

Seems to be working ok @steiza @vielmetti

cdzombak commented 5 years ago

🎉

Screen Shot 2019-09-11 at 5 03 35 PM

eby commented 5 years ago

I don't have merge permissions it seems but this seems good to go

cdzombak commented 5 years ago

@eby Thanks! Zach has communicated to me that he'll be able to review/merge later this month.

vielmetti commented 5 years ago

Very nice! 🎉

cdzombak commented 5 years ago

There's a few minor additional changes this inspires,

Indeed there are! Chief among them for me would be tracking upload times, not just dates; and reviewing the allowed HTML tags and refactoring/reorganizing some of the Bleach code, since there's some duplication there now (plus the use of a global variable as a "constant," which, yuck).

But that said…

but we could land this as-is (or if you want to update this diff, that's fine too).

I'd prefer to land & get this deployed as-is, if only because I don't know when I'll have time/bandwidth to keep working on this.

eby commented 5 years ago

:ship: Deployed to production. Let me know if you notice anything.

cdzombak commented 5 years ago

🚢 Deployed to production. Let me know if you notice anything.

Awesome! Thanks, everyone 🍻