search

steleman / address-sanitizer

Automatically exported from code.google.com/p/address-sanitizer
0 stars 0 forks source link

32-bit tests broken in trunk #308

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. build Clang on x86_64
2. run `make -j10 check-asan'
3. run `file 
projects/compiler-rt/test/asan/32bitConfig/TestCases/Output/printf-1.c.tmp'

What is the expected output?
  ELF 32-bit LSB executable

What do you see instead?
  ELF 64-bit LSB executable

Looks like the error was introduced in r207707. Here are the issues that I see 
with this revision:
* target_cflags got moved to test/lit.site.cfg.in from 
test/asan/lit.site.cfg.in; but COMPILER_RT_TEST_COMPILER_CFLAGS is still set in 
test/asan/CMakeLists.txt so it's not available when configuring 
test/lit.common.configure.in
* test/lit.common.configured.in uses COMPILER_RT_TEST_COMPILER_FLAGS instead of 
COMPILER_RT_TEST_COMPILER_CFLAGS

Original issue reported on code.google.com by tetra2...@gmail.com on 7 May 2014 at 3:07

GoogleCodeExporter commented 9 years ago 
Thanks for the detailed report.  Can you please confirm r207707 fixes the 
issues?

Original comment by gari...@gmail.com on 7 May 2014 at 7:32

GoogleCodeExporter commented 9 years ago 
sorry, fixed in r208240

Original comment by gari...@gmail.com on 7 May 2014 at 7:34

GoogleCodeExporter commented 9 years ago 
Seems to be working. Thanks!

Original comment by tetra2...@gmail.com on 8 May 2014 at 11:56