stella-emu / stella

A multi-platform Atari 2600 Emulator
https://stella-emu.github.io
GNU General Public License v2.0
621 stars 112 forks source link

Use a layout manager for dialogs #291

Open thrust26 opened 6 years ago

thrust26 commented 6 years ago

Currently the dialogs are designed using fixed pixels. A layout manager would allow much easier dialog definitions and also add flexibility to the dialogs (e.g. resizing, larger fonts etc.).

If we cannot find an out of the box layout manager class, I suggest using the concept of this Java TableLayout layout manager for our own one: http://www.clearthought.info/sun/products/jfc/tsc/articles/tablelayout/index.html Basically you define columns and rows, like for a table; each column/row can either have a fixed value, percentages of the available size or fill the remaining gaps; you then add widgets into the created table grid, each widget can span multiple cells) Example: http://www.clearthought.info/sun/products/jfc/tsc/articles/tablelayout/Simple.html

BTW: This looks interesting, but I suppose that would require way too much rework: https://github.com/dalerank/nanogui-sdl

sa666666 commented 6 years ago

After spending the better part of the past day looking over the UI code, I really wonder if we can justify the time to spend on this one. I think perhaps once I add a HiDPI mode, that will take care of users' with 4K and above monitors. Plus the fact that there are 3 fonts sizes available, I wonder how much further we should take this ...

thrust26 commented 6 years ago

IMO we should just reduce the prio here an keep it open. Maybe eventually someone has fun doing this.

sa666666 commented 6 years ago

OK, we may come back to this. But TBH, I'm getting burned out on the UI stuff, and want to start working on real emulator-related stuff. After all, Stella is a 2600 emulator project, not a GUI project. And for me, it seems to be more of the latter lately.

thrust26 commented 6 years ago

Agreed. Back to the core. Maybe we should focus on Prio 1 first (and fix the prios where necessary).

sa666666 commented 2 years ago

@thrust26, do you think this should remain? Honestly, I don't think there's much of a chance that someone will come along and work on this one. And I don't think I ever will either :smiling_imp:

thrust26 commented 2 years ago

Maybe I will eventually? 😄