search

stella-emu / stella

A multi-platform Atari 2600 Emulator
https://stella-emu.github.io
GNU General Public License v2.0
626 stars 111 forks source link

Images should also be searched by filename #911

Closed Augusto7743 closed 2 years ago

Augusto7743 commented 2 years ago

Hello. I has all roms inside one zip file. That file load correctly, but the screenshots not are showed even using correct naming. Which file image formats are allowed ?

THANKS VERY MUCH FOR ADDING OPTION TO TOGGLE AUTOFIRE =) Have an nice week.

thrust26 commented 2 years ago

Stella uses the PNG image file format. You can download a collection here. For me it shows all screenshots, even if the ROMs are in a zip-file.

If that answers your question, please confirm.

Augusto7743 commented 2 years ago

Thanks for your reply.

Stella browse an Roms.zip (inside all roms). In Stella launch is listed the roms.zip file. Select roms.zip is loaded an list of all files inside, but not show the screenshots even if the screenshot file is png using correct naming.

The path for screenshots use space. /Disc/Games/Stella Atari 2600/Images/R1

thrust26 commented 2 years ago

Did you setup Stella to use that path? (Options/User Interface/Launcher/Image Path)

Augusto7743 commented 2 years ago

Thanks for reply. Yes. Used the correct path in Launcher image path. Screenshots not are showed in stella launcher even using correct naming png.

thrust26 commented 2 years ago

Can you post your ROM file? Or parts of it? As long as it is not working, any ZIP is fine.

Augusto7743 commented 2 years ago

ROMs 1.zip

thrust26 commented 2 years ago

Works for me. image

Two more questions:

sa666666 commented 2 years ago

Works for me.

For me too.

One other thing to consider. The PNG snapshots have to be named as they are in the Stella internal database. So if you name them as they are in the file list above, then Stella can't find them.

I recommend to download them from https://stella-emu.github.io/downloads.html. The link is near the bottom of the page.

Augusto7743 commented 2 years ago

@thrust26 "Do ROMs outside a ZIP file display the screenshots?" Not

"Which OS are you using?" Lubuntu (Ubuntu using LXQT) 20.04.4

@sa666666 "The PNG snapshots have to be named as they are in the Stella internal database. So if you name them as they are in the file list above, then Stella can't find them" I has loaded an game and done an screenshot and after moving the file png to launcher image path. Not show any screenshot.

If load Enduro-NTSC.rom the correct is show screenshot if have Enduro-NTSC.png in launcher image path. If Stella load Enduro-NTSC.rom and not is in "internal database" even if the rom is an good dump not is possible show screenshots ? I use emulators for an long time and is the first time I see an emulator requiring screenshots to be named using "internal database" instead rom name. If it is the because not show any screenshot the emulator need allow show any screenshot not using "internal database".

thrust26 commented 2 years ago

"Do ROMs outside a ZIP file display the screenshots?" Not

OK, then the issue is not related to ZIP files.

I has loaded an game and done an screenshot and after moving the file png to launcher image path. Not show any screenshot.

This works for me. And if I e.g. take "Asteroids (1981) (Atari).bin", rename it into "123.bin" and put a screenshot named "123.png" into the image path, Stella will display this PNG. Without the "123.png", Stella will display the "Asteroids (1981) (Atari).png".

So Stella searches the PNG by ROM name first and then by internal database.

Augusto7743 commented 2 years ago

Tested ROM named

Activision Decathlon, The (USA).a26

Not show screenshot named below Activision Decathlon, The (USA).png (custom image) 500X680 70 KB

Activision Decathlon, The (USA).png (Stella screenshot) 1024X768 14,3 KB

If renaming the rom to Decathlon (1983) (Activision) [fixed].a26

The screenshots above are showed in Stella Launcher if renamed to Decathlon (1983) (Activision) [fixed].png

The user only has 2 choices :

That's an problem in Stella. If user wish to use roms named using TOSEC or Nointro because the roms naming has more details not is possible use Stella screenshot feature. Stella only allowing show screenshots if roms are named exactly using internal database not is correct.

thrust26 commented 2 years ago
  • use roms using internal naming without naming details for show screenshots, but if the rom not is in internal database not will show any screenshot.
  • use roms using TOSEC or Nointro with more naming details, but not will be showed any screenshots because Stella not allow it.

This is not correct. I tested your example. Stella does the following:

So, if you want e.g. "Activision Decathlon, The (USA).a26" to show an image, use the database name for the image. You can name your ROMs as you like.

Augusto7743 commented 2 years ago

That's not correct. I use emulators for long time ... is the first time I see an emulator only showing screenshots if named using internal database. Stella need allow both show exactly png file using the rom name and internal database.

thrust26 commented 2 years ago

Agreed. We will enhance Stella to first search for the internal name and then for the ROM name.

sa666666 commented 2 years ago

Seems pretty easy to fix.

Augusto7743 commented 2 years ago

Thanks very much. I has several custom png files (game box and cartridges) from Atariage. Would be good to see Stella allowing configure 3 paths for launcher screenshots view :

MAME has option to configure flyers, cabinets, gameplay screenshots and etc. MAME gui in screenshot area has buttons to alternate what type of screenshots (flyers, cabinets, gameplay screenshots and etc) will be showed and works very well. That feature is an good improvement for Stella.

thrust26 commented 2 years ago

Good suggestion.

The problem is, that we would need support here. We do not have the resources to create and maintain the additional images. And without images provides, this makes little sense.

Augusto7743 commented 2 years ago

I have roms named TOSEC and images of game box and cartridges from AtariAge both named using exact rom naming. It is more of 100 MB total size. If Stella devs allow I can to look both types of roms (TOSEC, Nointro and Stella database) and the chosen type will be named image file of both gamebox and cartridges. Then the images files can be uploaded for Stella devs see if are good. Stella rom database use Atarimania rom naming ?

thrust26 commented 2 years ago

Stella rom database use Atarimania rom naming ?

More or less, yes.

thrust26 commented 2 years ago

Seems pretty easy to fix.

Yup! 😄

Augusto7743 commented 2 years ago

Thanks very much !