stellar-comet / comet

☄️ A cross-platform app powered by FFmpeg for easy, beautiful media conversion.
https://comet.thavarshan.com
MIT License
71 stars 4 forks source link

Removed video files still get converted during ongoing conversions #26

Closed Thavarshan closed 5 days ago

Thavarshan commented 1 week ago

Comet: v1.0.0

Description

When a list of video files is uploaded for conversion and a file is removed from the list while the conversion is still in progress, the removed file continues to be converted in the background. Although the removed video no longer appears in the UI file list, it is still processed and converted. This behavior causes confusion, as users expect the removal of a file to cancel its conversion.

Steps To Reproduce

  1. Upload a list of video files for conversion.
  2. Start the conversion process.
  3. Remove a video from the file list while the conversion is still in progress.
  4. Observe that the removed file is no longer visible in the UI file list.
  5. Wait for the conversion to complete.
  6. Notice that the removed file is still converted, even though it was removed from the list.

Expected Behavior

When a video file is removed from the list during an ongoing conversion, the conversion for that specific file should be canceled, and the file should not be processed.

Actual Behavior

The removed file continues to be converted in the background, even though it no longer appears in the UI file list.

Additional Context

This issue could cause confusion, as users might assume the file was successfully removed and will not be processed. The removal action should cancel any ongoing conversion for that file to avoid unexpected behavior.