search

stellar-deprecated / account-viewer

DEPRECATED. Go to https://github.com/stellar/account-viewer-v2
Apache License 2.0
62 stars 65 forks source link

Update SDK to latest, support SEP-29 #112

Closed vcarl closed 4 years ago

vcarl commented 4 years ago

The Stellar SDK gets consumed via the interstellar-network package, which is deprecated and no longer maintained (by me). This PR overrides package.json to install it from local code, and edits the local code so that it uses the most recent SDK version.

Tested and confirmed this gets us SEP-29 (required memo) support but the error is a little ugly. I'll circle back before merging to get something a little prettier.

Screen Shot 2020-04-29 at 11 35 10 AM

GAJVUHQV535IYW25XBTWTCUXNHLQN4F2PGIPOOX4DDKL2UPNXUHWU7B3 is the test address I was using (I own secret key) to test memo required behavior.

stellar-jenkins commented 4 years ago

Preview is available here:
http://accountviewer-969643e.previews.kube001.services.stellar-ops.com/

vcarl commented 4 years ago

Updated:

Screen Shot 2020-05-05 at 12 50 47 PM

The "more info" link takes you to https://medium.com/stellar-community/help-i-forgot-my-stellar-memo-d62b3cc9c2f7

stellar-jenkins commented 4 years ago

Preview is available here:
http://accountviewer-21e7c25.previews.kube001.services.stellar-ops.com/

stellar-jenkins commented 4 years ago

Preview is available here:
http://accountviewer-559e3d4.previews.kube001.services.stellar-ops.com/

vcarl commented 4 years ago

Definitely rough, but this is a decent improvement for us maintaining. A little more predictable, and it's good to be on the latest version of the SDK!