search

stellar-deprecated / account-viewer

DEPRECATED. Go to https://github.com/stellar/account-viewer-v2
Apache License 2.0
62 stars 65 forks source link

Make memo less prominent. #55

Closed fnando closed 6 years ago

fnando commented 6 years ago

Memo can be very distracting. Some people are using it to spam users on the network. This change hides it behind an icon.

animation

I also changed how the loading state is represented by adding an image animation.

animation

zallarak commented 6 years ago

I actually think this could be detrimental. If someone wants to build a protocol on top of Stellar using micro transactions and memos, it would be nice to have it show up on a block explorer.

bartekn commented 6 years ago

You can still view it, it's just less visible.

fnando commented 6 years ago

@bartekn actually, this was reverted a while ago and I don't know why.

https://github.com/stellar/account-viewer/commit/59e29a53e58cfaad1563b8bc91444ecfcecf8b12

Could you explain why did the code get reverted, @tomerweller?

bartekn commented 6 years ago

We decided to use https://github.com/stellar/account-viewer/pull/59 instead.