stellar-deprecated / account-viewer

DEPRECATED. Go to https://github.com/stellar/account-viewer-v2
Apache License 2.0
62 stars 65 forks source link

Add Trezor support #70

Open zulucrypto opened 6 years ago

zulucrypto commented 6 years ago

I'm planning on implementing Trezor support but I'm opening an issue for initial discussion and feedback before I begin coding.

This will also depend on an update to the Trezor Connect project which is being tracked by this issue: https://github.com/trezor/connect/issues/127

As far as the actual implementation, I was planning on adding a "Sign in with Trezor" button under the "Sign in with Ledger" one and essentially copying the Ledger functionality.

spacesailor24 commented 5 years ago

Hi there,

I'm having difficulty trying to sign a transaction using Trezor model T and Stellar Account Viewer.

Please review my reddit post for more details, thank you.

https://www.reddit.com/r/Stellar/comments/abynfg/send_fails_with_stellar_account_viewer/?utm_source=reddit-android

spacesailor24 commented 5 years ago

Sorry, I'm just now seeing that the PR that implements Trezor support hasn't been merged.

reqlez commented 5 years ago

I tested sending with Trezor from the Account Viewer ( trezor.io/stellar/ ) and you are right! I get the following message:

**"Could not sign transaction: Trezor: Parameter "amount" has invalid type. "string" expected.

Warning We submitted your transaction to the network but because of the network conditions we are not certain about its status: it could either succeed or fail. Instead of recreating the transaction you should use the button below to safely resubmit the transaction: "** I was able to send funds into the Trezor account and I can see them fine, they update in real time too. What happens is that when I press send, a new chrome tab opens asking to connect to Trezor to "prepare transaction", I click allow, but nothing actually happens on the Trezor it does not show that I have to allow it on the device itself... and right after that, I get the error. So it seems that the request either never makes it to the Trezor, or I don't know what's up.

However, when I moved my funds to the Trezor account, I saw the balance but there was no option to set inflation destination, so I went ahead and used this: https://kolontsov.github.io/stellar-trezor-inflation/ and it connected to the Trezor T just fine and submitted the request to the network no problem with my signature. By the way, may I recommend to integrate this feature into Account Viewer? i'm sure lots of people will be asking.

So not sure, you say PR is not merged but how come trezor.io/stellar/ has the page up and running? They have forked the code here too... https://github.com/trezor/stellar-account-viewer/issues

prusnak commented 5 years ago

@spacesailor24 @reqlez should be fixed on https://trezor.io/stellar

spacesailor24 commented 5 years ago

@prusnak Thank you for the update! Will have to test myself at a later time.

reqlez commented 5 years ago

Actually, just tested with T and Chrome ( wihout the bridge software installed, if that matters ). Works great ! May I suggest getting the inflation destination code on the page going as well ;-)

leaenbinario commented 4 years ago

I get Error:"Failed to sign with Ledger device: U2F DEVICE_INELIGIBLE" when I try to use Sign with BIP Path