search

stellar-deprecated / kelp

Kelp is a free and open-source trading bot for the Stellar DEX and 100+ centralized exchanges
https://kelpbot.io
Other
1.09k stars 262 forks source link

centralized exchanges should not require details about stellar account or asset #135

Open nikhilsaraf opened 5 years ago

nikhilsaraf commented 5 years ago

Describe the bug

The bot should not require stellar's trading account and asset's issuer address when trading on centralized exchanges. Currently validation fails when we leave these values out when using centralized exchanges.

Expected behavior

I think the correct behavior in this situation is for the bot to not require stellar's trading account and asset's issuer address when trading on centralized exchanges.

Frequency

The frequency is: always

Your Environment

version: master:v1.5.0-28-gfeee8bb8
git branch: master
git hash: feee8bb8ea692421a92ca0214760d9e6d34314f3
build date: 20190321T211045Z
GOOS: linux
GOARCH: amd64
nikhilsaraf commented 5 years ago

this would require some careful changes since batchedExchanges uses the trading account in it's APIs. It's possible that this could be blank and it's never really used or validated, outside of the initial config init/validation function, but it needs a closer look

jiujiteiro commented 3 years ago

@nikhilsaraf any update on this? I ran into it myself trying to integrate with Okex. Are you open to a pull request?

nikhilsaraf commented 3 years ago

@jiujiteiro yes I'm open to a pull request. Can you add me on keybase (@nikhilsaraf) (preferred) or Twitter (@nikhilsaraf9), easier to ping me there with any questions if working on this issue.