stellar-deprecated / kelp

Kelp is a free and open-source trading bot for the Stellar DEX and 100+ centralized exchanges
https://kelpbot.io
Other
1.1k stars 260 forks source link

https://api.coinmarketcap.com/v1/ticker/ offline and kelp does not understand price feeds #392

Open toan85 opened 4 years ago

toan85 commented 4 years ago

Please support Cryptocompare https://min-api.cryptocompare.com/data/price?fsym=XLM&tsyms=USD and Binance api https://api.binance.com//api/v3/ticker/price?symbol=XLMUSDT. Because kelp does not understand Price Feeds crypto https://min-api.cryptocompare.com/data/price?fsym=XLM&tsyms=USD https://api.binance.com//api/v3/ticker/price?symbol=XLMUSDT and return error levels couldn't be loaded: mid price couldn't be loaded: json: cannot unmarshal object into Go value of type []plugins.cmcAPIReturn errors on both sides: buying (= ) and selling (= ).

nikhilsaraf commented 4 years ago

@toan85 binance price feeds are already supported in kelp.

If you want to run a price feed using binance you need to run ccxt: https://github.com/stellar/kelp#using-ccxt

see this for the config to run the binance price feed: https://github.com/stellar/kelp/blob/0caada7b4c370f43ebc02aacd7abdf265919dfe2/examples/configs/trader/sample_buysell.cfg#L27