search

stellar-deprecated / kelp

Kelp is a free and open-source trading bot for the Stellar DEX and 100+ centralized exchanges
https://kelpbot.io
Other
1.1k stars 261 forks source link

Stop-limit mode #83

Open Reidmcc opened 5 years ago

Reidmcc commented 5 years ago

Desired Behavior

I was to use Kelp to maintain stop-limit orders for the SDEX.

Impact

Stellar does not natively support stop-limit orders, and to my knowledge no web front ends for the SDEX do either. This is a non-trivial barrier to my willingness to trade in any way except market making.

Feature Suggestion

Add a strategy to have Kelp monitor the SDEX orderbook and place a sell order when the stop is triggered.

References

Stop-limit orders are commonplace on other cryptocurrency exchanges.

Additional context

I considered building an application to do this from scratch, but Kelp can already do it with a custom strategy, which is far more efficient than reinventing the wheel.

Specification

I have this coded, tested, and working. If you're interested I'll put in a pull request.

nikhilsaraf commented 5 years ago

@Reidmcc PR for this would be great

nikhilsaraf commented 5 years ago

@Reidmcc based on the implementation in #100 it seems like it's not an "automated" trading strategy just yet. it seems like we're only exposing one specific functionality of stop-limit orders via kelp. That's neat to have but I think would be better served by making this more "automated". I can see this being used when we have the Kelp GUI, where users can easily enter orders they want placed when a certain price is hit -- almost like their private trading terminal that provides stop limit capabilities.

See comment on review to #100 about suggested changes to make this more "automated". Happy to discuss this in detail if that's easier. Thanks!