search

stellar-deprecated / stellar-client

INACTIVE. Browser based client for stellard. This repository is inactive. It points to the stellard network, which is being replaced by stellar-core. Please refer to the replacement repository, interstellar-client, which points to the stellar-core network.
Other
306 stars 74 forks source link

Order Book Price Units Should Be Inversed #1100

Open RhettCreighton opened 9 years ago

RhettCreighton commented 9 years ago

Shouldn't it be 222222 STR / BTC, not 222222 BTC / STR?

screenshot

wynlim commented 9 years ago

@EverettForth: it depends on the way you saved your pair above. This is mine:

image

wynlim commented 9 years ago

Oh sorry, I realized the math is wrong anyway for your BTC/STR pair. Thanks!

deckar01 commented 9 years ago

I agree that the label should match the calculation. It was originally in the suggested order until https://github.com/stellar/stellar-client/issues/1035.

bekkibolthouse commented 9 years ago

If you think of the currency pairs as a single unit, where the base currency is first and the quote currency comes second (BASE/QUOTE). When you look at the trading client with this lens, you see that when you set your trading pairs, the currency that you intend to buy always displays as the BASE. So any offer to buy STR will read as "STR/QUOTE" and offers to buy BTC will read as "BTC/QUOTE." When you look at the order book, you see the spread in price between offers to buy the BASE (bids) and the offers to sell the BASE (asks). The forward slash shouldn't be interpreted as a math function, more like grammar or punctuation.