search

stellar-deprecated / stellar-client

INACTIVE. Browser based client for stellard. This repository is inactive. It points to the stellard network, which is being replaced by stellar-core. Please refer to the replacement repository, interstellar-client, which points to the stellar-core network.
Other
307 stars 74 forks source link

Use ui sref #1127

Closed deckar01 closed 9 years ago

deckar01 commented 9 years ago

Removed hard coded hrefs in favor of ui-sref. Changed instances of href="" to href="#" for IE compatibility.

Fixes #1091.

irisli commented 9 years ago

screen shot 2015-01-09 at 11 47 36 am

The Manage Issuers & Gateways button doesn't work here anymore. In https://github.com/stellar/stellar-client/issues/1091#issuecomment-66210007, this was what made me think that href would be better since there currently isn't a way (as far as I know) of adding a GET param to ui-sref links.

deckar01 commented 9 years ago

@irisli, you are right. I thought I tested it, but the link I used didn't actually have parameters.

http://stackoverflow.com/questions/25647454/how-to-pass-parameters-using-ui-sref-in-ui-router-to-controller

The accepted solution is a little more verbose and generic than we need, but contains some tricks we can use to get this working with ui-sref.

deckar01 commented 9 years ago

@irisli I added a commit that uses ng-click="gotoAddGateway()" which sets the action to add-gateway and navigates to the dashboard.

irisli commented 9 years ago

Pulled and tested add gateway link. Maybe in the future with modular client, there would be a more unified way to do this, but as of now, this works fine. :+1: