search

stellar-deprecated / stellar-client

INACTIVE. Browser based client for stellard. This repository is inactive. It points to the stellard network, which is being replaced by stellar-core. Please refer to the replacement repository, interstellar-client, which points to the stellar-core network.
Other
306 stars 74 forks source link

Add wallet address to "Identify" #1130

Open bekkibolthouse opened 9 years ago

bekkibolthouse commented 9 years ago

Users can now merge and delete accounts; usernames can be reclaimed. This has the potential to create account name collision in our data set. Please start collecting wallet address to Identify users. Currently, we rely upon the federated username only. @dirtyanalytics and @tammycamp

jpetey75 commented 9 years ago

If you guys switch to identifying based on wallet address there will be a period of time where many users are double counted in Amplitude, is that ok? Basically "active users" is based on a 30 day window so if a user is active and gets re-identified with wallet address Amplitude thinks it's a new user, but still also thinks the old username is a unique user.

If wallet address is a better unique key in the long term it's probably better to make the switch sooner than later.

All that needs to be done is update any and all calls to analytics.identify to look something like this:

analytics.identify(user.wallet_address, {
  username: user.username,
  email: user.email
});

(plus any other traits that are currently in the calls)

bekkibolthouse commented 9 years ago

Holding pattern on this; usernames with deletedAt timestamp cannot be reclaimed at this time.