search

stellar-deprecated / stellar-client

INACTIVE. Browser based client for stellard. This repository is inactive. It points to the stellard network, which is being replaced by stellar-core. Please refer to the replacement repository, interstellar-client, which points to the stellar-core network.
Other
305 stars 75 forks source link

Update password strength meter #1178

Open bartekn opened 9 years ago

bartekn commented 9 years ago

@bekkibolthouse

Password strength meter on client says "Password1" was a "good" password (3 out of 4 bars!) -- this is a common password that would be easy to crack by a modest attack.

Consider library used by coinbase and wealthfront among other money-handling companies: https://github.com/dropbox/zxcvbn

Originally in: https://github.com/stellar/stellar-api/issues/63

gterzian commented 9 years ago

I'm writing some tests for the relevant controllers, to make any change/refactoring easier. https://github.com/stellar/stellar-client/pull/1181

If you do decide to switch to this library (which looks excellent by the way), I'de be up for making the change too.

bekkibolthouse commented 9 years ago

@gterzian sounds great. Can I introduce you via email to another dev who has offered to help with the same? Shoot me a message at bekki at stellar dot org. Thanks!

gterzian commented 9 years ago

@bekkibolthouse did you ever receive my email, I guess you all must have been very busy :smile: In any case let me know if I can help with anything.

bekkibolthouse commented 9 years ago

@gterzian I sent an email your way on March 17th but will resend now with more context. Thanks for the reminder!

gterzian commented 9 years ago

@bekkibolthouse got it thanks! sorry for missing that email before!