search

stellar-deprecated / stellar-client

INACTIVE. Browser based client for stellard. This repository is inactive. It points to the stellard network, which is being replaced by stellar-core. Please refer to the replacement repository, interstellar-client, which points to the stellar-core network.
Other
307 stars 74 forks source link

Default state for trading client #853

Open wynlim opened 9 years ago

wynlim commented 9 years ago

This is for first-time users and for users who do not have a last used trade, can we show prefill the form fields with some default values?

"1" for the first currency and last transacted price for "each priced at" ?

image

irisli commented 9 years ago

Filling in a default pair has been done. We still need to put a default price.

Issue half complete

jedmccaleb commented 9 years ago

What do you set the default currency to?

irisli commented 9 years ago

I did not implement it, just commenting here. As of right now, it is set to no currency

jedmccaleb commented 9 years ago

Filling in a default pair has been done. What does that mean then?

It is actually hard to come up with a reasonable default since it depends on what gateways they have added. Maybe STR for first currency of first gateway? But I'd not worry about this for now.

wynlim commented 9 years ago

"Maybe STR for first currency of first gateway?"

I rather have something naive like this in place, because right now it is not very user-friendly when there's no currencies at all displayed. or we can have "select currency" when it is null, for now.

irisli commented 9 years ago

As I understand, it seems like there are actually 3 different things going on in this discussion now:

Issue 1: Setting a list of default favorites. There is another (and another) issue talking about this specifically: https://github.com/stellar/stellar-client/issues/855

Issue 2: Fill in the default base currency amount

I'm against filling it with a default value of 1 because most of the time, users will not be trading 1 of that amount. Also, it adds more friction as users have to delete a default value every time. With a default value of 1, users may end up with this problem (except with a 1 in the beginning): https://github.com/stellar/stellar-client/issues/845

Also, 1 BTC is a huge amount of money while 1 STR is a fraction of a penny.

Instead, I think it would be better to have a placeholder of 0. and when the user clicks into the text input, the placeholder disappears and they can start typing without worrying about a placeholder they might not use.

Issue 3: Fill in the default "each priced at" amount

I think this is good and that this value should be at a price where they meet the other side of the spread.

wynlim commented 9 years ago

Would really like to have "Fill in the default "each priced at" amount" because less advanced users wouldn't really know how to work out spreads or the order book.

irisli commented 9 years ago

Yeah, I agree with you on that. That is Issue 3.

What about Issue 2? (unselectable placeholder 0 or a non-deletable 0 default)

wynlim commented 9 years ago

It is already 0 by default, let's leave it that way for now.

My preferable default state will have default positive values filled in, including having a default pair, but since we're not doing default pairs, it doesn't make sense to have positive values as well.

I'm hoping we'll change our minds, because an empty form is intimidating.

irisli commented 9 years ago

I think it should be a placeholder 0 though, so that once you click, you can start typing and you don't have to delete.

Right now, the 0 there means that users have to delete the leading zero every trade

irisli commented 9 years ago

From an internal discussion, we can make it a placeholder if it's doable.