stellar-expert / albedo

Security-centric, developer-friendly, easy-to-use delegated signer and keystore for Stellar Network
https://albedo.link
MIT License
64 stars 14 forks source link

TX intent fails to display when pubkey is given and CreateAccountOperation present in tx #27

Closed salessandri closed 3 years ago

salessandri commented 3 years ago

I ran into the following issue. I have a transaction that I want the user to sign, this transaction contains a CreateAccountOperation. If the pubkey is not present in the params given to the tx intent, things are displayed correctly. But I want to restrict the user to signing with a specific public key. When I set the pubkey param, Albedo starts loading and then shows a blank page.

I debugged it a bit and found that it is making a request to horizon for the account being created and of course, that returns a 404. This seems to be triggering the failure.

This is the info I'm using:

salessandri commented 3 years ago

It might actually be that there is a second operation targeting the account being created in the first operation and the signature of that key is not present. We just want a partial signature, we will add the other signature once the signed transaction is sent back to us.

kalepail commented 3 years ago

I'm having this issue as well with partially signed transactions. No create account ops, just some payment and trustline stuff.

Screen Shot 2020-10-02 at 8 43 58 AM

pubkey:

GDJ4Z462LHYFDBMYGFTI2GX7BFMMCG7WCTSNDBA4RQR6I7GLF2WNQIO3

xdr:

AAAAAgAAAADTzPPaWfBRhZgxZo0a/wlYwRv2FOTRhByMI+R8yy6s2AAAASwAD5VoAAAABAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAMAAAABAAAAAMin4RRGdDMjnKeCauKRjwqYsKkkGtPcEOj10Sn+AYToAAAAAQAAAADTzPPaWfBRhZgxZo0a/wlYwRv2FOTRhByMI+R8yy6s2AAAAAAAAAABKgXyAAAAAAAAAAAGAAAAAlNRMDAwMgAAAAAAAAAAAABRi+a3Ix5QqRhcC/Bqa+8wBYkQVlREPUvx07dipfHABwAAAAAAAAABAAAAAQAAAABRi+a3Ix5QqRhcC/Bqa+8wBYkQVlREPUvx07dipfHABwAAAAEAAAAA08zz2lnwUYWYMWaNGv8JWMEb9hTk0YQcjCPkfMsurNgAAAACU1EwMDAyAAAAAAAAAAAAAFGL5rcjHlCpGFwL8Gpr7zAFiRBWVEQ9S/HTt2Kl8cAHAAAAAAAAAAEAAAAAAAAAAqXxwAcAAABAcH8Kb/KizKD2xPNF75fVdUKibGEKiY1Tq4NyQfjmtgpXOKWrPFxhGwdUm/U7Oosqs5QYaPeDMHKHtspEWXvwBP4BhOgAAABAjGVZnczQYJRCPOIGhoGXimylYVytcM46gP/gtd6wCB/1oRbVeeApx3nvsmYIe/DfzfKN++EUPN5Frco33N9ECA==
orbitlens commented 3 years ago

Fixed in v0.9.3 Thanks for the heads up!