search

stellar-expert / albedo

Security-centric, developer-friendly, easy-to-use delegated signer and keystore for Stellar Network
https://albedo.link
MIT License
64 stars 14 forks source link

Detect when user close browser tab without taking any action on intent-action-view #60

Closed ralphilius closed 3 years ago

ralphilius commented 3 years ago

This is useful when integrating with Albedo, so that we could handle this case.

orbitlens commented 3 years ago

Hello,

Sorry for the late response. I missed the notification. I double-checked and it looks like Albedo always responds with actionRejectedByUser (code -4) error when the Albedo confirmation window/tab is closed. You can check it here for example: https://albedo.link/playground?section=public_key

Could you please provide more context on this problem? What browser are you using? Maybe it's an iframe-embedded integration case built specifically for the StellarQuest?

ralphilius commented 3 years ago

Hi @orbitlens,

I was trying to add Albedo to Stellar Laboratory for transaction signing. When debugging, I couldn't get any actionRejectedByUser when I just closed the confirmation tab. You can try with the latest code from this repo: https://github.com/stellar/laboratory

orbitlens commented 3 years ago

Ok, looks like I found the root of the problem. Now it works flawlessly with the Laboratory on my end. Could you please check it on your side? (you might need to clean cache for the origin https://albedo.link)

orbitlens commented 3 years ago

@ralphilius Did you have a chance to check whether everything works on your side now?

ralphilius commented 3 years ago

I didn't have a chance to take a look yet. Could you explain what action I should take on my side to make it work?

On Tue, Aug 17, 2021, 16:47 OrbitLens @.***> wrote:

@ralphilius https://github.com/ralphilius Did you have a chance to check whether everything works on your side now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stellar-expert/albedo/issues/60#issuecomment-900152490, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOO36RESY2W4RYAOF2MWTT5IV2NANCNFSM5BFVJXPA .

orbitlens commented 3 years ago

@ralphilius No need to take any actions. I checked on https://laboratory.stellar.org/ with several browsers on different platforms and it worked flawlessly. I just need a confirmation to close this bug.

ralphilius commented 3 years ago

@orbitlens Confirmed. When closing the tab, it shows an error in Lab UI.