search

stellar / account-viewer-v2

A simple tool to view an account on the Stellar network and make transactions from it.
37 stars 25 forks source link

deps: bump trezor-connect to v9 #391

Closed overcat closed 1 year ago

overcat commented 2 years ago

Trezor v8 related npm packages are now in maintenance mode, future updates will be based on Trezor v9

https://github.com/trezor/trezor-suite/issues/5358

Hannsek commented 1 year ago

Closes https://github.com/stellar/account-viewer-v2/issues/393

overcat commented 1 year ago

Blocked by https://github.com/stellar/js-stellar-wallets/pull/333

Since this project depends on stellar/js-stellar-wallets, but js-stellar-wallets is still using the old version of trezor-connect.

quietbits commented 1 year ago

@overcat, there is a chance that updated Trezor will not work through js-stellar-wallets here if it uses WebUSB. We had to implement Ledger connect locally for the Account Viewer because of WebUSB restrictions. I don't remember the details, but it was something to do with only direct action that could launch something—using a library sort of created a 3rd party in the middle, which wasn't allowed. Maybe Trezor handles it differently, wanted to bring this up just in case.

We could just go ahead and implement Trezor connect locally as well, to remove dependency on js-stellar-wallets.

overcat commented 1 year ago

Hi @quietbits, it looks like I forgot to remove the reference to trezor-connect, but I have now fixed it. I have also tested it on the latest versions of Chrome and Firefox and it seems to be running smoothly.

https://account-viewer-v2-160ixf0uc-overcat.vercel.app/