stellar / dashboard

https://dashboard.stellar.org
217 stars 139 forks source link

Transactions Module #274

Closed jcx120 closed 2 years ago

jcx120 commented 2 years ago

Build a "Transactions" container component with the following elements:

  1. Transactions Per Second (TPS): 120
  2. Historical TPS - last 30 days (Nice to have)
    • Graph chart of average daily TPS over past 30 days, MainNet only
  3. Recent Operations
    • See legacy Dashboard
    • Last 10
    • Fields: Source Operation | Details | Time ago

Considerations:

raphaelmartins1993 commented 2 years ago

@jcx120 Where we can get these operations? Horizon or Hubble? If Hubble, which tables?

jcx120 commented 2 years ago

For 1+2) see the github link to see how they calculate it. There might also be something available in Hubble but will need to check 3) This is an existing module in the current Dashboard v1 The API: https://horizon.stellar.org/operations?order=desc&limit=10 (We can limit it to 10)

raphaelmartins1993 commented 2 years ago

hello @jcx120, in the historical TPS of the transactions module we should always bring the last 30 days fixed, or should we also have the possibility of filters such as 1 hour, 1 day, 30 days? thanks!

jcx120 commented 2 years ago

@raphaelmartins1993 If this is easy to do, then let's have the 1hr, 1day, 30 day filter to keep it consistent with other metrics. Otherwise, let's keep it fixed at 30 days.

lccoronel commented 2 years ago

Hi @jcx120 and @quietbits, we just did the transactions component with "Transactions Per Second" and "Historical TPS", what do you think of the layout?

Screen Shot 2022-06-28 at 15 58 21
jcx120 commented 2 years ago

I think it looks fine. We can have UX @cbshin-stellar review it once a staging instance is available so it can be seen in context.

lccoronel commented 2 years ago

I think it looks fine. We can have UX @cbshin-stellar review it once a staging instance is available so it can be seen in context.

ok, we have a preview here: https://dashboard-pr293.prototypes.kube001.services.stellar-ops.com/?network=mainnet

lccoronel commented 2 years ago

@jcx120 and @quietbits, another thing, I noticed that the "RECENT OPERATIONS: LIVE NETWORK" table on dashboard v1 some data is treated that is not returning in the horizon API like:

like others fields.

code

Are these data retrieved at some point in an operation or can we disregard them?

jcx120 commented 2 years ago

Cool! I'm assuming the Fees module and Ledger module are coming soon correct?

lccoronel commented 2 years ago

yes, we are intending to finish this in the next days

sdfcharles commented 2 years ago

UX and visuals look great! no feedback to add, it's pretty 1:1 with the design so I'm happy with how the staging looks currently

sdfcharles commented 2 years ago

For Recent Operations, we can limit the number of items displayed to 10 rows.

lccoronel commented 2 years ago

Hi @jcx120, we still need to check this account?

code

I was chatting with @quietbits and I had this doubt?

acharb commented 2 years ago

@lccoronel let's remove it, doesn't look critical to me

jcx120 commented 2 years ago

@lccoronel For the "Transactions Per Second" Module, lets:

  1. Move the "Current TPS" box to be above the graph
  2. Change the "Transactions" label for the graph to be "Average Daily Transactions"

This is so the most important info is available at the top. thanks

jcx120 commented 2 years ago

@lccoronel Looking good and thanks for the updates. One minor text change: For the "Ledger Operations" module, please update the "Operations" text (next to the dot) to be "Total monthly operations"

lccoronel commented 2 years ago

302