stellar / dashboard

https://dashboard.stellar.org
217 stars 139 forks source link

Ledger module #275

Closed jcx120 closed 2 years ago

jcx120 commented 2 years ago

Build a "Ledger" container component with the following elements:

  1. Operations Capacity: Monthly graph of Operations (million) (y axis) vs Time (x axis) with a static max red line indicating capacity limit (Operations (million) per month)
    • Data is in Hubble
  2. % Operations Capacity Utilized current month
    • This is a current month view of utilization

Considerations:

raphaelmartins1993 commented 2 years ago

@jcx120 Could you bring us more information about this link? We donโ€™t have permission to access it.

We want to know the maximum capacity to display the red line in the chart.

If you can explain more about what information we need to use in Hubble.

jcx120 commented 2 years ago

For this module, the query is in Hubble. For details we can reach out to @bartekn The link is just the original slack thread that has the context (but not the query)

bartekn commented 2 years ago

I don't have a specific query because I'm using a BigQuery connector for Google Spreadsheet (so the queries are generated automatically by pivot tables). The data is pulled from history_ledgers table that contains number of operations per ledger. Then you can aggregate per month-year.

raphaelmartins1993 commented 2 years ago

Hi @jcx120. We have a question about the trendline that is displayed in the graph. Since we haven't seen any specification about it, we would like to know if it should be shown or not? If it should be displayed, can you tell us if it is calculated or static? Thank you very much!

jcx120 commented 2 years ago

That trendline is not MVP scope and can be left out (I think its a r^2 trendline generated in excel).

We do want that Max red line which is a constant for the maximum # of operations per month based on theoretical capacity of 5000 operations per second. @bartekn can you share that number? thanks

bartekn commented 2 years ago

@bartekn can you share that number? thanks

It's 518,400,000.

There are 12 ledgers in a minute on average (60/5=12) so in a month, given the 1000 ops/ledger limit:

12*1000*60*24*30 = 518400000
italomlp commented 2 years ago

Here are some screenshots of the possible final chart for this module. Feedback is much appreciated, maybe for changing some colors, spacings, etc. LMK your thoughts @jcx120

Click to see screenshots: PS: I'm using fake values, don't take them into account. Screen Shot 2022-06-09 at 15 18 35 Screen Shot 2022-06-09 at 15 18 42 Screen Shot 2022-06-09 at 15 18 51
jcx120 commented 2 years ago

I like option 3 but once its prototyped we can also have our UX designer provide input. thanks

italomlp commented 2 years ago

Oh, sorry, maybe I was not so clear. They are the same component, in light and dark mode variants. Also, the one that has a tooltip (image 2) is just the light mode variant with the mouse hovering over the chart. Does that make sense?

Selhar commented 2 years ago

Quick question regarding the operations capacity. How can we get the max capacity? For operations per day/hour/month we already fetch it on the ledgers endpoint, but we don't have the maximum capacity value for these intervals.

bartekn commented 2 years ago

Here's how you can calculate it.

lccoronel commented 2 years ago

@acharb and @jcx120, in the graph of the ledgers module, do you need to have a period variation?

Screen Shot 2022-07-08 at 10 40 50

Or will we have a fixed period?

acharb commented 2 years ago

@lccoronel I think we want just the month timeline, based off of what @jcx120 said here

  1. Operations Capacity: Monthly graph of Operations
lccoronel commented 2 years ago

@acharb, @jcx120 and @bartekn, Is this red line right?

Screen Shot 2022-07-11 at 15 08 07
jcx120 commented 2 years ago

@lccoronel I believe the units are missing 3 extra digits. So 518k should be 518 Million. We can label the value as "(Millions)" and put a decimal after the first 3 digits. Ie: 518.400 (Millions). See the sample in the original doc.

lccoronel commented 2 years ago

@lccoronel I believe the units are missing 3 extra digits. So 518k should be 518 Million. We can label the value as "(Millions)" and put a decimal after the first 3 digits. Ie: 518.400 (Millions). See the sample in the original doc.

Actually we wrote 518 Million ๐Ÿ˜…

code

If we put the million label, the chart looks like this

Screen Shot 2022-07-11 at 16 02 51
jcx120 commented 2 years ago

@lccoronel Indeed you did it correctly! I need new glasses. ๐Ÿ˜…

lccoronel commented 2 years ago

302