stellar / dashboard

https://dashboard.stellar.org
217 stars 139 forks source link

SDFD-26: feat fee stats table #292

Closed lccoronel closed 2 years ago

lccoronel commented 2 years ago
  1. Average Transaction Fee: 0.0002 XLM

  2. Base reserve: 0.5 XLM

    • Src: static variable from code
  3. Base operation fee: 0.00001 XLM

    • Src: static variable from code

Screen:

Screen Shot 2022-07-19 at 10 59 33
  1. Graph of Average Transaction Fee over time (24hr, 30d)

  2. For Average Transaction Fee, we can use this sample query in Hubble to get the average over the last 30 days:

Screen:

Screen Shot 2022-07-19 at 10 59 25
  1. Fee Stats (Last 5 Ledgers)

    • Metric | Value

Screen:

Screen Shot 2022-07-19 at 10 59 48
stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

acharb commented 2 years ago

are there mockups of what this should look like or a requirements list for adding these fee stats?

duh it's this https://github.com/stellar/dashboard/issues/273, nvrm :)

acharb commented 2 years ago

also looks like the first data value for the Average Transaction Fee data is NaN:

Screen Shot 2022-07-19 at 3 52 45 PM

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

acharb commented 2 years ago

fyi looks like the chart isn't loading in the latest preview

Screen Shot 2022-07-20 at 9 23 41 AM
lccoronel commented 2 years ago

fyi looks like the chart isn't loading in the latest preview

Screen Shot 2022-07-20 at 9 23 41 AM

Yes, we are having a problem with the request

Screen Shot 2022-07-20 at 13 51 21
Selhar commented 2 years ago

Was this loading previously? I believe we don't have a cache for fees yet on the preview environment's redis. For context, the preview environment is unable to make bigquery requests, so it relies exclusively on redis.

stellar-jenkins commented 2 years ago

Preview is available here:
https://dashboard-pr292.prototypes.kube001.services.stellar-ops.com/

acharb commented 2 years ago

Was this loading previously? I believe we don't have a cache for fees yet on the preview environment's redis. For context, the preview environment is unable to make bigquery requests, so it relies exclusively on redis.

ah right, sorry you can ignore. I can add that later today

acharb commented 2 years ago

added to redis

jcx120 commented 2 years ago

@lccoronel

For the module containing "Average Transaction Fee, Base Operation Fee..." etc:

Also, in terms of layout, is there a way to move the "Fee stats" module to be nested under this section and within the same UI container? Example: FeeModule

lccoronel commented 2 years ago

@jcx120 about third item, the correct calcule is:

code

the average transaction fee per day divided by 100 stroops(0.00001 XLM), it’s right ?

lccoronel commented 2 years ago

@jcx120 about fourth item, is this how you imagine the stroops link?

Screen Shot 2022-07-25 at 15 39 16

we put the link on the right.

jcx120 commented 2 years ago

@lccoronel Let's put the Stroops link on the "STROOPS" word on the left side (not as a separate link).

jcx120 commented 2 years ago

@lccoronel The current Average Transaction Fee looks like it needs to be multiplied by 0.00001 to get XLM. It is showing currently stroops but is labeled as XLM.

jcx120 commented 2 years ago

@lccoronel Looks great. 2 more adjustments for the "Transaction Fee Info:" module:

  1. Let's put that "Average Transaction Fee" module with the 24hr|30D graph to be inside the "Transaction Fee Info" module, below the last 5 ledgers fee stats module.
  2. Label this module: "Average Transaction Fee by Day (In Stroops):" vs "Average Transaction Fee" so its different than the other one above with the same name.