search

stellar / django-polaris

An extendable Django app for building modular Stellar services
https://django-polaris.readthedocs.io
Apache License 2.0
94 stars 66 forks source link

ENABLE_SEP_0023="true" missing on documentation #644

Closed ajuricabense closed 1 year ago

ajuricabense commented 1 year ago

What version are you using?

2.3.1

What did you do?

The documentation of version 2.3.1 of the environmental variables did not specify to add: ENABLE_SEP_0023="true", which raises the error:

File "/home/alfredo/MEGA_c/2021_2022/Alpaca/stellar/virtualenv/lib/python3.8/site-packages/polaris/apps.py", line 66, in check_sep23_supported raise ImproperlyConfigured( django.core.exceptions.ImproperlyConfigured: environment variable ENABLE_SEP_0023 must be set to 'true'

Please add in the documentation the complete lines: ACTIVE_SEPS= HOST_URL=http://localhost:8000 LOCAL_MODE=1 ENABLE_SEP_0023="true"

What did you expect to see?

What did you see instead?

JakeUrban commented 1 year ago

I wouldn't consider this a bug, our documentation just needs to be updated.

JakeUrban commented 1 year ago

Actually, this check was removed in v2.3, are you sure you're using the latest version?

JakeUrban commented 1 year ago

https://github.com/stellar/django-polaris/pull/617

ajuricabense commented 1 year ago

@JakeUrban How can I check the version I am using? to be sure.

JakeUrban commented 1 year ago

It should be in your requirements lock file like poetry.lock or pipfile.lock, or just requirements.txt

ajuricabense commented 1 year ago

@JakeUrban You are correct, I made a mistake, my version is django-polaris==2.2.0

JakeUrban commented 1 year ago

No problem! I'll close the issue.