stellar / freighter

Stellar browser extension
81 stars 25 forks source link

[QA] Use class instead of css var for hasNoTopPadding toggle #1647

Closed aristidesstaffieri closed 1 week ago

aristidesstaffieri commented 1 week ago

What Use class instead of css var for hasNoTopPadding toggle

Why During QA we decided to remove the padding from some of our view insets. This uncovered a bug in how our hasNoTopPadding prop worked. Since this prop toggled a css variable, if two components were rendered at once and set this flag opposite of each other, you can experience clashes due to the nature of css cascading.