stellar / freighter

Stellar browser extension
81 stars 25 forks source link

Skip password when creating a new address #1682

Closed CassioMG closed 3 days ago

CassioMG commented 3 days ago

Closes https://github.com/stellar/freighter/issues/923

This PR implements the following changes as discussed on the issue:

*Note: this PR is based on feature/maintain-password-2 branch since it relies on changes from this other PR.

Creating a new address when password is saved

https://github.com/user-attachments/assets/c7d6f33a-5899-4c3e-bc9e-535d5d5f4115

Creating a new address when password is NOT saved

https://github.com/user-attachments/assets/83436042-c4a3-4127-8a98-f056d1fd5ca7

Auth error while creating a new address

https://github.com/user-attachments/assets/3dc6caa4-fcc3-440b-96e9-0b28b7f60c9f

CassioMG commented 3 days ago

After the automatic base branch switch it appears this PR is showing more changes then it should have.

So closing this in favor of https://github.com/stellar/freighter/pull/1685 which contains only the changes related to this task.