search

stellar / go

Stellar's public monorepo of go code
https://stellar.org/developers
Apache License 2.0
1.3k stars 499 forks source link

exp/services/webauth: send application name to Horizon #2752

Open leighmcculloch opened 4 years ago

leighmcculloch commented 4 years ago

What

Send application name, but not version, in requests to Horizon using the Go SDKs config AppName field.

Why

So that when running the webauth service alongside Horizon with other services that interact with Horizon, it is possible to distuingish in logs which requests have come from the webauth service and therefore possible to generate metrics on the usage of the Horizon API by the webauth service.

ire-and-curses commented 4 years ago

Could you expand on the "Why" a little? I'm having trouble grasping what this does.

leighmcculloch commented 4 years ago

Could you expand on the "Why" a little? I'm having trouble grasping what this does.

Expanded. Let me know if that makes more sense.