Open morleyzhi opened 5 years ago
@Akuukis @charlie-wasp I've kicked off gears for this, I'm pinging you since you both show interests on helping with this :).
I created a branch called typescript
where we can start merging updates. The first PR was very basic, it added TS to package.json and rename all the file https://github.com/stellar/js-stellar-base/pull/216
Now we need to make npx tsc
to actually work and setup the build/test pipeline. If you want to start updating files, I'll suggest you leave a comment here telling which files you are working on, so we don't overlap on each others work :). Also let's try to do small PRs so we can review and merge more easily.
Let's do this! 🚀
@abuiles Here's a batch of migrations:
any
number[]
to Buffer-alike that needs investigationsrc/browser.ts
need anything at all? LGTM as it is.@abuiles I believe, I'm pretty late for the party 😅 But it seems, that work is not over yet. How can I help here? Should I take some unchecked points from the top comment and work on them?
@charlie-wasp hey! Better late than never -- we still got some work to do. I'm happy if you can help on this, we have a branch with the current changes - we can continue work off that branch.
This is a more direct way to address #183, and to add type safety to the library.
TODOs (copied from js-stellar-sdk migration)
npx tsc
ts-loader
won't run on Webpack 1typescript
branch as an alphaFiles WIP